Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7574)

Unified Diff: chrome/browser/ui/webui/shared_resources_data_source.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/shared_resources_data_source.cc
===================================================================
--- chrome/browser/ui/webui/shared_resources_data_source.cc (revision 176942)
+++ chrome/browser/ui/webui/shared_resources_data_source.cc (working copy)
@@ -10,7 +10,6 @@
#include "base/memory/singleton.h"
#include "base/threading/thread_restrictions.h"
#include "chrome/browser/io_thread.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/common/url_constants.h"
#include "grit/generated_resources.h"
#include "grit/shared_resources.h"
@@ -51,16 +50,17 @@
return chrome::kChromeUIResourcesHost;
}
-void SharedResourcesDataSource::StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) {
+void SharedResourcesDataSource::StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) {
int idr = PathToIDR(path);
DCHECK_NE(-1, idr) << " path: " << path;
const ResourceBundle& rb = ResourceBundle::GetSharedInstance();
scoped_refptr<base::RefCountedStaticMemory> bytes(
rb.LoadDataResourceBytes(idr));
- url_data_source()->SendResponse(request_id, bytes);
+ callback.Run(bytes);
}
std::string SharedResourcesDataSource::GetMimeType(

Powered by Google App Engine
This is Rietveld 408576698