chrome/browser/ui/webui/ntp/ntp_resource_cache.cc - Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc » ('j') | content/public/browser/url_data_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

===================================================================

--- chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (revision 176942)

+++ chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (working copy)

@@ -27,12 +27,12 @@

#include "chrome/browser/themes/theme_service_factory.h"

#include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"

#include "chrome/browser/ui/search/search.h"

-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

#include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

#include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"

#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"

#include "chrome/browser/ui/webui/sync_setup_handler.h"

+#include "chrome/browser/ui/webui/web_ui_util.h"

#include "chrome/browser/web_resource/notification_promo.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

@@ -298,7 +298,7 @@

prefs::kShowBookmarkBar);

localized_strings.SetBoolean("bookmarkbarattached", bookmark_bar_attached);

- URLDataSource::SetFontAndTextDirection(&localized_strings);

+ web_ui_util::SetFontAndTextDirection(&localized_strings);

static const base::StringPiece incognito_tab_html(

ResourceBundle::GetSharedInstance().GetRawDataResource(

@@ -415,7 +415,7 @@

NewTabPageHandler::GetLocalizedValues(profile_, &load_time_data);

NTPLoginHandler::GetLocalizedValues(profile_, &load_time_data);

- URLDataSource::SetFontAndTextDirection(&load_time_data);

+ web_ui_util::SetFontAndTextDirection(&load_time_data);

// Control fade and resize animations.

load_time_data.SetBoolean("anim", ui::Animation::ShouldRenderRichAnimation());