Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3722)

Unified Diff: chrome/browser/ui/webui/ntp/thumbnail_source.h

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/thumbnail_source.h
===================================================================
--- chrome/browser/ui/webui/ntp/thumbnail_source.h (revision 176942)
+++ chrome/browser/ui/webui/ntp/thumbnail_source.h (working copy)
@@ -9,7 +9,7 @@
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
-#include "content/public/browser/url_data_source_delegate.h"
+#include "content/public/browser/url_data_source.h"
class Profile;
@@ -23,15 +23,16 @@
// ThumbnailSource is the gateway between network-level chrome: requests for
// thumbnails and the history/top-sites backend that serves these.
-class ThumbnailSource : public content::URLDataSourceDelegate {
+class ThumbnailSource : public content::URLDataSource {
public:
explicit ThumbnailSource(Profile* profile);
- // content::URLDataSourceDelegate implementation.
+ // content::URLDataSource implementation.
virtual std::string GetSource() OVERRIDE;
- virtual void StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) OVERRIDE;
+ virtual void StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) OVERRIDE;
virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
virtual MessageLoop* MessageLoopForRequestPath(
const std::string& path) const OVERRIDE;
@@ -39,9 +40,6 @@
private:
virtual ~ThumbnailSource();
- // Send the default thumbnail when we are missing a real one.
- void SendDefaultThumbnail(int request_id);
-
// Raw PNG representation of the thumbnail to show when the thumbnail
// database doesn't have a thumbnail for a webpage.
scoped_refptr<base::RefCountedMemory> default_thumbnail_;

Powered by Google App Engine
This is Rietveld 408576698