chrome/browser/ui/webui/history_ui.cc - Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/history_ui.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/history_ui.cc

===================================================================

--- chrome/browser/ui/webui/history_ui.cc (revision 176942)

+++ chrome/browser/ui/webui/history_ui.cc (working copy)

@@ -157,8 +157,8 @@

void BrowsingHistoryHandler::RegisterMessages() {

// Create our favicon data source.

Profile* profile = Profile::FromWebUI(web_ui());

- ChromeURLDataManager::AddDataSource(profile,

- new FaviconSource(profile, FaviconSource::FAVICON));

+ ChromeURLDataManager::AddDataSource(

+ profile, new FaviconSource(profile, FaviconSource::FAVICON));

// Get notifications when history is cleared.

registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,

@@ -506,8 +506,8 @@

web_ui->AddMessageHandler(new BrowsingHistoryHandler());

// Set up the chrome://history-frame/ source.

- ChromeURLDataManager::AddDataSource(Profile::FromWebUI(web_ui),

- CreateHistoryUIHTMLSource());

+ ChromeURLDataManager::AddDataSourceImpl(Profile::FromWebUI(web_ui),

+ CreateHistoryUIHTMLSource());

}

// static

« no previous file with comments | « chrome/browser/ui/webui/help/help_ui.cc ('k') | chrome/browser/ui/webui/inspect_ui.cc » ('j') | content/public/browser/url_data_source.h » ('J')