chrome/browser/ui/webui/chrome_url_data_manager_backend.h - Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chrome_url_data_manager_backend.h

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chrome_url_data_manager.cc ('k') | chrome/browser/ui/webui/chrome_url_data_manager_backend.cc » ('j') | content/public/browser/url_data_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chrome_url_data_manager_backend.h

===================================================================

--- chrome/browser/ui/webui/chrome_url_data_manager_backend.h (revision 176942)

+++ chrome/browser/ui/webui/chrome_url_data_manager_backend.h (working copy)

@@ -44,7 +44,7 @@

ChromeURLDataManagerBackend* backend);

// Adds a DataSource to the collection of data sources.

- void AddDataSource(URLDataSource* source);

+ void AddDataSource(URLDataSourceImpl* source);

// DataSource invokes this. Sends the data to the URLRequest.

void DataAvailable(RequestID request_id, base::RefCountedMemory* bytes);

@@ -56,7 +56,7 @@

friend class URLRequestChromeJob;

typedef std::map<std::string,

- scoped_refptr<URLDataSource> > DataSourceMap;

+ scoped_refptr<URLDataSourceImpl> > DataSourceMap;

typedef std::map<RequestID, URLRequestChromeJob*> PendingRequestMap;

// Called by the job when it's starting up.

@@ -66,7 +66,7 @@

// Helper function to call StartDataRequest on |source|'s delegate. This is

// needed because while we want to call URLDataSourceDelegate's method, we

// need to add a refcount on the source.

- static void CallStartRequest(scoped_refptr<URLDataSource> source,

+ static void CallStartRequest(scoped_refptr<URLDataSourceImpl> source,

const std::string& path,

bool is_incognito,

int request_id);