Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
haraken, scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions/renderer: Use v8::Local instead of v8::Handle. Turns out, Handle is just an alias for Local: https://chromium.googlesource.com/v8/v8.git/+/master/include/v8.h#334 BUG=424445 R=scheib@chromium.org Committed: https://crrev.com/f85316f2347d04f10ecc1bb8114aec6a9cd5c87a Cr-Commit-Position: refs/heads/master@{#327515}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -343 lines) Patch
M extensions/renderer/activity_log_converter_strategy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/binding_generating_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/binding_generating_native_handler.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M extensions/renderer/console.h View 1 chunk +6 lines, -6 lines 0 comments Download
M extensions/renderer/console.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M extensions/renderer/dispatcher.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 9 chunks +21 lines, -21 lines 0 comments Download
M extensions/renderer/document_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dom_activity_logger.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/dom_activity_logger.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/event_bindings.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/extension_frame_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/extension_frame_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 8 chunks +24 lines, -25 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M extensions/renderer/json_schema_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/logging_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/logging_native_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 8 chunks +23 lines, -29 lines 0 comments Download
M extensions/renderer/module_system.h View 8 chunks +17 lines, -17 lines 0 comments Download
M extensions/renderer/module_system.cc View 27 chunks +59 lines, -61 lines 0 comments Download
M extensions/renderer/module_system_test.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/renderer/module_system_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M extensions/renderer/render_view_observer_natives.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.h View 1 chunk +4 lines, -4 lines 0 comments Download
M extensions/renderer/resource_bundle_source_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/safe_builtins.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/script_context.h View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/script_context.cc View 7 chunks +17 lines, -17 lines 0 comments Download
M extensions/renderer/script_context_set.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context_set.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/send_request_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/user_gestures_native_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/renderer/utils_native_handler.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M extensions/renderer/v8_schema_registry.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
PTAL
5 years, 7 months ago (2015-04-29 05:11:09 UTC) #1
haraken
LGTM, thanks for doing this!
5 years, 7 months ago (2015-04-29 11:49:34 UTC) #2
scheib
LGTM
5 years, 7 months ago (2015-04-29 16:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115563002/1
5 years, 7 months ago (2015-04-29 16:56:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 17:03:48 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 17:04:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f85316f2347d04f10ecc1bb8114aec6a9cd5c87a
Cr-Commit-Position: refs/heads/master@{#327515}

Powered by Google App Engine
This is Rietveld 408576698