extensions/renderer/api_test_base.cc - Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_test_base.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/activity_log_converter_strategy_unittest.cc ('k') | extensions/renderer/app_window_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api_test_base.cc

diff --git a/extensions/renderer/api_test_base.cc b/extensions/renderer/api_test_base.cc

index e18cbbb78ff8562287206710b255e6c085f74ec0..53d6fa4923870a17efc05f602f84e20bca28d6ad 100644

--- a/extensions/renderer/api_test_base.cc

+++ b/extensions/renderer/api_test_base.cc

@@ -205,7 +205,7 @@ void ApiTestEnvironment::RunTestInner(const std::string& test_name,

const base::Closure& quit_closure) {

v8::HandleScope scope(env()->isolate());

ModuleSystem::NativesEnabledScope natives_enabled(env()->module_system());

- v8::Handle<v8::Value> result =

+ v8::Local<v8::Value> result =

env()->module_system()->CallModuleMethod("testBody", test_name);

if (!result->IsTrue()) {

base::MessageLoop::current()->PostTask(FROM_HERE, quit_closure);