Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
index d71d6a29ade270996e1969dcde4f6d6caf43268b..c8b6afa41a2a7af2d679d360fecc4b9cfcbaab34 100644
--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
@@ -38,7 +38,7 @@ class ScriptableObject : public gin::Wrappable<ScriptableObject>,
public:
static gin::WrapperInfo kWrapperInfo;
- static v8::Handle<v8::Object> Create(
+ static v8::Local<v8::Object> Create(
v8::Isolate* isolate,
base::WeakPtr<MimeHandlerViewContainer> container) {
ScriptableObject* scriptable_object =
@@ -209,7 +209,7 @@ void MimeHandlerViewContainer::didFinishLoading(
}
void MimeHandlerViewContainer::PostMessage(v8::Isolate* isolate,
- v8::Handle<v8::Value> message) {
+ v8::Local<v8::Value> message) {
if (!guest_loaded_) {
linked_ptr<v8::Global<v8::Value>> global(
new v8::Global<v8::Value>(isolate, message));
@@ -231,16 +231,15 @@ void MimeHandlerViewContainer::PostMessage(v8::Isolate* isolate,
v8::Local<v8::Object> guest_proxy_window =
guest_proxy_frame->mainWorldScriptContext()->Global();
gin::Dictionary window_object(isolate, guest_proxy_window);
- v8::Handle<v8::Function> post_message;
+ v8::Local<v8::Function> post_message;
if (!window_object.Get(std::string(kPostMessageName), &post_message))
return;
- v8::Handle<v8::Value> args[] = {
- message,
- // Post the message to any domain inside the browser plugin. The embedder
- // should already know what is embedded.
- gin::StringToV8(isolate, "*")
- };
+ v8::Local<v8::Value> args[] = {
+ message,
+ // Post the message to any domain inside the browser plugin. The embedder
+ // should already know what is embedded.
+ gin::StringToV8(isolate, "*")};
guest_proxy_frame->callFunctionEvenIfScriptDisabled(
post_message.As<v8::Function>(),
guest_proxy_window,

Powered by Google App Engine
This is Rietveld 408576698