Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: extensions/renderer/extension_helper.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/extension_helper.h" 5 #include "extensions/renderer/extension_helper.h"
6 6
7 #include "content/public/renderer/render_view.h" 7 #include "content/public/renderer/render_view.h"
8 #include "content/public/renderer/render_view_visitor.h" 8 #include "content/public/renderer/render_view_visitor.h"
9 #include "extensions/common/constants.h" 9 #include "extensions/common/constants.h"
10 #include "extensions/common/extension_messages.h" 10 #include "extensions/common/extension_messages.h"
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 browser_window_id_ = window_id; 215 browser_window_id_ = window_id;
216 } 216 }
217 217
218 void ExtensionHelper::OnAddMessageToConsole(ConsoleMessageLevel level, 218 void ExtensionHelper::OnAddMessageToConsole(ConsoleMessageLevel level,
219 const std::string& message) { 219 const std::string& message) {
220 console::AddMessage(render_view(), level, message); 220 console::AddMessage(render_view(), level, message);
221 } 221 }
222 222
223 void ExtensionHelper::OnAppWindowClosed() { 223 void ExtensionHelper::OnAppWindowClosed() {
224 v8::HandleScope scope(v8::Isolate::GetCurrent()); 224 v8::HandleScope scope(v8::Isolate::GetCurrent());
225 v8::Handle<v8::Context> v8_context = 225 v8::Local<v8::Context> v8_context =
226 render_view()->GetWebView()->mainFrame()->mainWorldScriptContext(); 226 render_view()->GetWebView()->mainFrame()->mainWorldScriptContext();
227 ScriptContext* script_context = 227 ScriptContext* script_context =
228 dispatcher_->script_context_set().GetByV8Context(v8_context); 228 dispatcher_->script_context_set().GetByV8Context(v8_context);
229 if (!script_context) 229 if (!script_context)
230 return; 230 return;
231 script_context->module_system()->CallModuleMethod("app.window", 231 script_context->module_system()->CallModuleMethod("app.window",
232 "onAppWindowClosed"); 232 "onAppWindowClosed");
233 } 233 }
234 234
235 } // namespace extensions 235 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/extension_frame_helper.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698