extensions/renderer/send_request_natives.cc - Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/send_request_natives.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/renderer/script_context_set.cc ('k') | extensions/renderer/user_gestures_native_handler.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "extensions/renderer/send_request_natives.h"	5 #include "extensions/renderer/send_request_natives.h"

6	6

7 #include "base/json/json_reader.h"	7 #include "base/json/json_reader.h"

8 #include "content/public/child/v8_value_converter.h"	8 #include "content/public/child/v8_value_converter.h"

9 #include "extensions/renderer/request_sender.h"	9 #include "extensions/renderer/request_sender.h"

10 #include "extensions/renderer/script_context.h"	10 #include "extensions/renderer/script_context.h"

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 has_callback,	67 has_callback,

68 for_io_thread,	68 for_io_thread,

69 static_cast<base::ListValue*>(value_args.get()));	69 static_cast<base::ListValue*>(value_args.get()));

70 }	70 }

71	71

72 void SendRequestNatives::GetGlobal(	72 void SendRequestNatives::GetGlobal(

73 const v8::FunctionCallbackInfo<v8::Value>& args) {	73 const v8::FunctionCallbackInfo<v8::Value>& args) {

74 CHECK_EQ(1, args.Length());	74 CHECK_EQ(1, args.Length());

75 CHECK(args[0]->IsObject());	75 CHECK(args[0]->IsObject());

76 args.GetReturnValue().Set(	76 args.GetReturnValue().Set(

77 v8::Handle<v8::Object>::Cast(args[0])->CreationContext()->Global());	77 v8::Local<v8::Object>::Cast(args[0])->CreationContext()->Global());

78 }	78 }

79	79

80 } // namespace extensions	80 } // namespace extensions

OLD	NEW