Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.h
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.h b/extensions/renderer/guest_view/extensions_guest_view_container.h
index 75e21698d9d35c9847b71182a6efd4631f9b53af..f1a6622a436f715be1c7d5f1ed1fe305d6c2cfa2 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.h
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.h
@@ -25,7 +25,7 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
class Request {
public:
Request(GuestViewContainer* container,
- v8::Handle<v8::Function> callback,
+ v8::Local<v8::Function> callback,
v8::Isolate* isolate);
virtual ~Request();
@@ -33,13 +33,13 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
virtual void HandleResponse(const IPC::Message& message) = 0;
void ExecuteCallbackIfAvailable(int argc,
- scoped_ptr<v8::Handle<v8::Value>[]> argv);
+ scoped_ptr<v8::Local<v8::Value>[]> argv);
GuestViewContainer* container() const { return container_; }
bool HasCallback() const;
- v8::Handle<v8::Function> GetCallback() const;
+ v8::Local<v8::Function> GetCallback() const;
v8::Isolate* isolate() const { return isolate_; }
@@ -58,7 +58,7 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
AttachRequest(GuestViewContainer* container,
int guest_instance_id,
scoped_ptr<base::DictionaryValue> params,
- v8::Handle<v8::Function> callback,
+ v8::Local<v8::Function> callback,
v8::Isolate* isolate);
~AttachRequest() override;
@@ -73,7 +73,7 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
class DetachRequest : public Request {
public:
DetachRequest(GuestViewContainer* container,
- v8::Handle<v8::Function> callback,
+ v8::Local<v8::Function> callback,
v8::Isolate* isolate);
~DetachRequest() override;
@@ -87,9 +87,9 @@ class ExtensionsGuestViewContainer : public GuestViewContainer {
static ExtensionsGuestViewContainer* FromID(int element_instance_id);
void IssueRequest(linked_ptr<Request> request);
- void RegisterDestructionCallback(v8::Handle<v8::Function> callback,
+ void RegisterDestructionCallback(v8::Local<v8::Function> callback,
v8::Isolate* isolate);
- void RegisterElementResizeCallback(v8::Handle<v8::Function> callback,
+ void RegisterElementResizeCallback(v8::Local<v8::Function> callback,
v8::Isolate* isolate);
// BrowserPluginDelegate implementation.
« no previous file with comments | « extensions/renderer/extension_helper.cc ('k') | extensions/renderer/guest_view/extensions_guest_view_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698