Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1805)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index 8bc2a2e83174b37f688553f4de785e89dc67f3ec..2310d3dcbc92255798d27d5a080172246f78ee5b 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -91,11 +91,9 @@ void GuestViewInternalCustomBindings::AttachGuest(
linked_ptr<ExtensionsGuestViewContainer::Request> request(
new ExtensionsGuestViewContainer::AttachRequest(
- guest_view_container,
- guest_instance_id,
- params.Pass(),
- args.Length() == 4 ? args[3].As<v8::Function>() :
- v8::Handle<v8::Function>(),
+ guest_view_container, guest_instance_id, params.Pass(),
+ args.Length() == 4 ? args[3].As<v8::Function>()
+ : v8::Local<v8::Function>(),
args.GetIsolate()));
guest_view_container->IssueRequest(request);
@@ -123,9 +121,8 @@ void GuestViewInternalCustomBindings::DetachGuest(
linked_ptr<ExtensionsGuestViewContainer::Request> request(
new ExtensionsGuestViewContainer::DetachRequest(
- guest_view_container,
- args.Length() == 2 ? args[1].As<v8::Function>() :
- v8::Handle<v8::Function>(),
+ guest_view_container, args.Length() == 2 ? args[1].As<v8::Function>()
+ : v8::Local<v8::Function>(),
args.GetIsolate()));
guest_view_container->IssueRequest(request);
@@ -209,8 +206,8 @@ void GuestViewInternalCustomBindings::RunWithGesture(
blink::WebScopedUserGesture user_gesture;
CHECK_EQ(args.Length(), 1);
CHECK(args[0]->IsFunction());
- v8::Handle<v8::Value> no_args;
- context()->CallFunction(v8::Handle<v8::Function>::Cast(args[0]), 0, &no_args);
+ v8::Local<v8::Value> no_args;
+ context()->CallFunction(v8::Local<v8::Function>::Cast(args[0]), 0, &no_args);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698