Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: extensions/renderer/activity_log_converter_strategy.h

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 5 #ifndef EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
6 #define EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 6 #define EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "content/public/child/v8_value_converter.h" 10 #include "content/public/child/v8_value_converter.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 // This class is used by activity logger and extends behavior of 15 // This class is used by activity logger and extends behavior of
16 // V8ValueConverter. It overwrites conversion of V8 arrays and objects. When 16 // V8ValueConverter. It overwrites conversion of V8 arrays and objects. When
17 // converting arrays and objects, we must not invoke any JS code which may 17 // converting arrays and objects, we must not invoke any JS code which may
18 // result in triggering activity logger. In such case, the log entries will be 18 // result in triggering activity logger. In such case, the log entries will be
19 // generated due to V8 object conversion rather than extension activity. 19 // generated due to V8 object conversion rather than extension activity.
20 class ActivityLogConverterStrategy 20 class ActivityLogConverterStrategy
21 : public content::V8ValueConverter::Strategy { 21 : public content::V8ValueConverter::Strategy {
22 public: 22 public:
23 typedef content::V8ValueConverter::Strategy::FromV8ValueCallback 23 typedef content::V8ValueConverter::Strategy::FromV8ValueCallback
24 FromV8ValueCallback; 24 FromV8ValueCallback;
25 25
26 ActivityLogConverterStrategy(); 26 ActivityLogConverterStrategy();
27 ~ActivityLogConverterStrategy() override; 27 ~ActivityLogConverterStrategy() override;
28 28
29 // content::V8ValueConverter::Strategy implementation. 29 // content::V8ValueConverter::Strategy implementation.
30 bool FromV8Object(v8::Handle<v8::Object> value, 30 bool FromV8Object(v8::Local<v8::Object> value,
31 base::Value** out, 31 base::Value** out,
32 v8::Isolate* isolate, 32 v8::Isolate* isolate,
33 const FromV8ValueCallback& callback) const override; 33 const FromV8ValueCallback& callback) const override;
34 bool FromV8Array(v8::Handle<v8::Array> value, 34 bool FromV8Array(v8::Local<v8::Array> value,
35 base::Value** out, 35 base::Value** out,
36 v8::Isolate* isolate, 36 v8::Isolate* isolate,
37 const FromV8ValueCallback& callback) const override; 37 const FromV8ValueCallback& callback) const override;
38 38
39 private: 39 private:
40 bool FromV8Internal(v8::Handle<v8::Object> value, 40 bool FromV8Internal(v8::Local<v8::Object> value,
41 base::Value** out, 41 base::Value** out,
42 v8::Isolate* isolate, 42 v8::Isolate* isolate,
43 const FromV8ValueCallback& callback) const; 43 const FromV8ValueCallback& callback) const;
44 44
45 DISALLOW_COPY_AND_ASSIGN(ActivityLogConverterStrategy); 45 DISALLOW_COPY_AND_ASSIGN(ActivityLogConverterStrategy);
46 }; 46 };
47 47
48 } // namespace extensions 48 } // namespace extensions
49 49
50 #endif // EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 50 #endif // EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
OLDNEW
« no previous file with comments | « no previous file | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698