Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: extensions/renderer/module_system_unittest.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/module_system_test.cc ('k') | extensions/renderer/native_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/module_system_unittest.cc
diff --git a/extensions/renderer/module_system_unittest.cc b/extensions/renderer/module_system_unittest.cc
index 23ad2547b52c8a253c8021fc266ffa929505661c..e687841d9d120b48fb7a5daa235ccdabfd16f22e 100644
--- a/extensions/renderer/module_system_unittest.cc
+++ b/extensions/renderer/module_system_unittest.cc
@@ -141,7 +141,7 @@ TEST_F(ModuleSystemTest, TestLazyField) {
env()->module_system());
env()->RegisterModule("lazy", "exports.x = 5;");
- v8::Handle<v8::Object> object = env()->CreateGlobal("object");
+ v8::Local<v8::Object> object = env()->CreateGlobal("object");
env()->module_system()->SetLazyField(object, "blah", "lazy", "x");
@@ -162,7 +162,7 @@ TEST_F(ModuleSystemTest, TestLazyFieldYieldingObject) {
"object.y = function() { return 10; };"
"exports.object = object;");
- v8::Handle<v8::Object> object = env()->CreateGlobal("object");
+ v8::Local<v8::Object> object = env()->CreateGlobal("object");
env()->module_system()->SetLazyField(object, "thing", "lazy", "object");
@@ -184,7 +184,7 @@ TEST_F(ModuleSystemTest, TestLazyFieldIsOnlyEvaledOnce) {
"requireNative('counter').Increment();"
"exports.x = 5;");
- v8::Handle<v8::Object> object = env()->CreateGlobal("object");
+ v8::Local<v8::Object> object = env()->CreateGlobal("object");
env()->module_system()->SetLazyField(object, "x", "lazy", "x");
@@ -203,7 +203,7 @@ TEST_F(ModuleSystemTest, TestRequireNativesAfterLazyEvaluation) {
ModuleSystem::NativesEnabledScope natives_enabled_scope(
env()->module_system());
env()->RegisterModule("lazy", "exports.x = 5;");
- v8::Handle<v8::Object> object = env()->CreateGlobal("object");
+ v8::Local<v8::Object> object = env()->CreateGlobal("object");
env()->module_system()->SetLazyField(object, "x", "lazy", "x");
env()->RegisterModule("test",
@@ -218,7 +218,7 @@ TEST_F(ModuleSystemTest, TestTransitiveRequire) {
env()->RegisterModule("dependency", "exports.x = 5;");
env()->RegisterModule("lazy", "exports.output = require('dependency');");
- v8::Handle<v8::Object> object = env()->CreateGlobal("object");
+ v8::Local<v8::Object> object = env()->CreateGlobal("object");
env()->module_system()->SetLazyField(object, "thing", "lazy", "output");
« no previous file with comments | « extensions/renderer/module_system_test.cc ('k') | extensions/renderer/native_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698