Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: extensions/renderer/binding_generating_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/binding_generating_native_handler.h ('k') | extensions/renderer/console.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/binding_generating_native_handler.cc
diff --git a/extensions/renderer/binding_generating_native_handler.cc b/extensions/renderer/binding_generating_native_handler.cc
index b502d1d5ac5a33aaf6ed86b883288da4baf4183a..2f5dc6f442d48ee282e389dff302a45e69c92bd5 100644
--- a/extensions/renderer/binding_generating_native_handler.cc
+++ b/extensions/renderer/binding_generating_native_handler.cc
@@ -14,26 +14,26 @@ BindingGeneratingNativeHandler::BindingGeneratingNativeHandler(
const std::string& bind_to)
: module_system_(module_system), api_name_(api_name), bind_to_(bind_to) {}
-v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
+v8::Local<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
v8::Isolate* isolate = module_system_->GetIsolate();
v8::EscapableHandleScope scope(isolate);
- v8::Handle<v8::Object> binding_module =
+ v8::Local<v8::Object> binding_module =
module_system_->Require("binding")->ToObject(isolate);
- v8::Handle<v8::Object> binding =
+ v8::Local<v8::Object> binding =
binding_module->Get(v8::String::NewFromUtf8(isolate, "Binding"))
->ToObject(isolate);
- v8::Handle<v8::Function> create_binding =
+ v8::Local<v8::Function> create_binding =
binding->Get(v8::String::NewFromUtf8(isolate, "create"))
.As<v8::Function>();
- v8::Handle<v8::Value> argv[] = {
+ v8::Local<v8::Value> argv[] = {
v8::String::NewFromUtf8(isolate, api_name_.c_str())};
- v8::Handle<v8::Object> binding_instance =
+ v8::Local<v8::Object> binding_instance =
create_binding->Call(binding, arraysize(argv), argv)->ToObject(isolate);
- v8::Handle<v8::Function> generate =
+ v8::Local<v8::Function> generate =
binding_instance->Get(v8::String::NewFromUtf8(isolate, "generate"))
.As<v8::Function>();
v8::Local<v8::Object> object = v8::Object::New(isolate);
- v8::Handle<v8::Value> compiled_schema =
+ v8::Local<v8::Value> compiled_schema =
generate->Call(binding_instance, 0, NULL);
if (!compiled_schema.IsEmpty()) {
object->Set(v8::String::NewFromUtf8(isolate, bind_to_.c_str()),
« no previous file with comments | « extensions/renderer/binding_generating_native_handler.h ('k') | extensions/renderer/console.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698