Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: extensions/renderer/dom_activity_logger.h

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // blink::WebDOMActivityLogger implementation. 45 // blink::WebDOMActivityLogger implementation.
46 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends 46 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends
47 // it over to the browser (via IPC) for appending it to the extension activity 47 // it over to the browser (via IPC) for appending it to the extension activity
48 // log. 48 // log.
49 // These methods don't have the override keyword due to the complexities it 49 // These methods don't have the override keyword due to the complexities it
50 // introduces when changes blink apis. 50 // introduces when changes blink apis.
51 virtual void logGetter(const blink::WebString& api_name, 51 virtual void logGetter(const blink::WebString& api_name,
52 const blink::WebURL& url, 52 const blink::WebURL& url,
53 const blink::WebString& title); 53 const blink::WebString& title);
54 virtual void logSetter(const blink::WebString& api_name, 54 virtual void logSetter(const blink::WebString& api_name,
55 const v8::Handle<v8::Value>& new_value, 55 const v8::Local<v8::Value>& new_value,
56 const blink::WebURL& url, 56 const blink::WebURL& url,
57 const blink::WebString& title); 57 const blink::WebString& title);
58 virtual void logSetter(const blink::WebString& api_name, 58 virtual void logSetter(const blink::WebString& api_name,
59 const v8::Handle<v8::Value>& new_value, 59 const v8::Local<v8::Value>& new_value,
60 const v8::Handle<v8::Value>& old_value, 60 const v8::Local<v8::Value>& old_value,
61 const blink::WebURL& url, 61 const blink::WebURL& url,
62 const blink::WebString& title); 62 const blink::WebString& title);
63 virtual void logMethod(const blink::WebString& api_name, 63 virtual void logMethod(const blink::WebString& api_name,
64 int argc, 64 int argc,
65 const v8::Handle<v8::Value>* argv, 65 const v8::Local<v8::Value>* argv,
66 const blink::WebURL& url, 66 const blink::WebURL& url,
67 const blink::WebString& title); 67 const blink::WebString& title);
68 virtual void logEvent(const blink::WebString& event_name, 68 virtual void logEvent(const blink::WebString& event_name,
69 int argc, 69 int argc,
70 const blink::WebString* argv, 70 const blink::WebString* argv,
71 const blink::WebURL& url, 71 const blink::WebURL& url,
72 const blink::WebString& title); 72 const blink::WebString& title);
73 73
74 // Helper function to actually send the message across IPC. 74 // Helper function to actually send the message across IPC.
75 void SendDomActionMessage(const std::string& api_call, 75 void SendDomActionMessage(const std::string& api_call,
76 const GURL& url, 76 const GURL& url,
77 const base::string16& url_title, 77 const base::string16& url_title,
78 DomActionType::Type call_type, 78 DomActionType::Type call_type,
79 scoped_ptr<base::ListValue> args); 79 scoped_ptr<base::ListValue> args);
80 80
81 // The id of the extension with which this logger is associated. 81 // The id of the extension with which this logger is associated.
82 std::string extension_id_; 82 std::string extension_id_;
83 83
84 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger); 84 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger);
85 }; 85 };
86 86
87 } // namespace extensions 87 } // namespace extensions
88 88
89 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 89 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
90 90
OLDNEW
« no previous file with comments | « extensions/renderer/document_custom_bindings.cc ('k') | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698