Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: extensions/renderer/event_bindings.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/dom_activity_logger.cc ('k') | extensions/renderer/extension_frame_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/event_bindings.cc
diff --git a/extensions/renderer/event_bindings.cc b/extensions/renderer/event_bindings.cc
index 31fbffb726839acf2548e267bf001497c21c4a01..e7876fa8bf40d9dcb5f92966362ba855a7ba5367 100644
--- a/extensions/renderer/event_bindings.cc
+++ b/extensions/renderer/event_bindings.cc
@@ -83,24 +83,24 @@ bool IsLazyBackgroundPage(content::RenderView* render_view,
helper->view_type() == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
}
-EventFilteringInfo ParseFromObject(v8::Handle<v8::Object> object,
+EventFilteringInfo ParseFromObject(v8::Local<v8::Object> object,
v8::Isolate* isolate) {
EventFilteringInfo info;
- v8::Handle<v8::String> url(v8::String::NewFromUtf8(isolate, "url"));
+ v8::Local<v8::String> url(v8::String::NewFromUtf8(isolate, "url"));
if (object->Has(url)) {
- v8::Handle<v8::Value> url_value(object->Get(url));
+ v8::Local<v8::Value> url_value(object->Get(url));
info.SetURL(GURL(*v8::String::Utf8Value(url_value)));
}
- v8::Handle<v8::String> instance_id(
+ v8::Local<v8::String> instance_id(
v8::String::NewFromUtf8(isolate, "instanceId"));
if (object->Has(instance_id)) {
- v8::Handle<v8::Value> instance_id_value(object->Get(instance_id));
+ v8::Local<v8::Value> instance_id_value(object->Get(instance_id));
info.SetInstanceID(instance_id_value->IntegerValue());
}
- v8::Handle<v8::String> service_type(
+ v8::Local<v8::String> service_type(
v8::String::NewFromUtf8(isolate, "serviceType"));
if (object->Has(service_type)) {
- v8::Handle<v8::Value> service_type_value(object->Get(service_type));
+ v8::Local<v8::Value> service_type_value(object->Get(service_type));
info.SetServiceType(*v8::String::Utf8Value(service_type_value));
}
return info;
@@ -315,7 +315,7 @@ void EventBindings::MatchAgainstEventFilter(
// have a routingId in their filter.
MatcherIDs matched_event_filters = event_filter.MatchEvent(
event_name, info, context()->GetRenderView()->GetRoutingID());
- v8::Handle<v8::Array> array(
+ v8::Local<v8::Array> array(
v8::Array::New(isolate, matched_event_filters.size()));
int i = 0;
for (MatcherIDs::iterator it = matched_event_filters.begin();
« no previous file with comments | « extensions/renderer/dom_activity_logger.cc ('k') | extensions/renderer/extension_frame_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698