Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/renderer/script_context.h

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index 1f6ce400dc6c1c0001626770d5cfcea115f3cbf8..73579b9c3de060058de12bce934ace05d7895bdd 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -37,7 +37,7 @@ class ExtensionSet;
// Extensions wrapper for a v8 context.
class ScriptContext : public RequestSender::Source {
public:
- ScriptContext(const v8::Handle<v8::Context>& context,
+ ScriptContext(const v8::Local<v8::Context>& context,
blink::WebLocalFrame* frame,
const Extension* extension,
Feature::Context context_type,
@@ -64,7 +64,7 @@ class ScriptContext : public RequestSender::Source {
// A context becomes invalid via Invalidate().
bool is_valid() const { return is_valid_; }
- v8::Handle<v8::Context> v8_context() const {
+ v8::Local<v8::Context> v8_context() const {
return v8::Local<v8::Context>::New(isolate_, v8_context_);
}
@@ -108,11 +108,11 @@ class ScriptContext : public RequestSender::Source {
// must do that if they want.
//
// USE THIS METHOD RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
- v8::Local<v8::Value> CallFunction(v8::Handle<v8::Function> function,
+ v8::Local<v8::Value> CallFunction(v8::Local<v8::Function> function,
int argc,
- v8::Handle<v8::Value> argv[]) const;
+ v8::Local<v8::Value> argv[]) const;
- void DispatchEvent(const char* event_name, v8::Handle<v8::Array> args) const;
+ void DispatchEvent(const char* event_name, v8::Local<v8::Array> args) const;
// Fires the onunload event on the unload_event module.
void DispatchOnUnloadEvent();
« no previous file with comments | « extensions/renderer/safe_builtins.cc ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698