Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

This parameter is unused in almost every class derived from WebContentsObserver.
This will make refactoring the OnDid{Start|Stop}Loading IPCs from
WebContentsImpl to RenderFrameHostImpl simpler.

BUG=429399, 450799
Committed: https://crrev.com/6ce28f57d686337e99099a7a97354f45d22ca2f6
Cr-Commit-Position: refs/heads/master@{#321341}

[Fabrice (no longer in Chrome), 2015-03-13 17:22:22]

fdegans@chromium.org changed reviewers:
+ nasko@chromium.org

[Fabrice (no longer in Chrome), 2015-03-13 17:22:23]

As discussed, PTAL.
Almost all of these are purely mechanical changes, except for these 2 files:
chrome/browser/tab_contents/navigation_metrics_recorder.cc
extensions/browser/guest_view/guest_view_base.cc

[nasko, 2015-03-14 00:01:02]

nasko@chromium.org changed reviewers:
+ fsamuel@chromium.org

[nasko, 2015-03-14 00:01:04]

Just nits to replace NULL with nullptr, while refactoring.

Added Fady to look over the webview changes, as he is the owner of that area.

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3831: SetIsLoading(false,
true, NULL);
nit: nullptr

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3939: SetIsLoading(true,
to_different_document, NULL);
nit: nullptr

https://codereview.chromium.org/1008913002/diff/20001/content/test/test_web_c...
File content/test/test_web_contents.cc (right):

https://codereview.chromium.org/1008913002/diff/20001/content/test/test_web_c...
content/test/test_web_contents.cc:142: SetIsLoading(value, true, NULL);
nit: nullptr

[Fady Samuel, 2015-03-14 04:25:02]

guest_view lgtm + nit.

https://codereview.chromium.org/1008913002/diff/40001/extensions/browser/gues...
File extensions/browser/guest_view/guest_view_base.cc (left):

https://codereview.chromium.org/1008913002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/guest_view_base.cc:522: if
(IsPreferredSizeModeEnabled()) {
nit: Could you please get rid of these unnecessary braces while you're at it?
Thanks!

[Fabrice (no longer in Chrome), 2015-03-16 11:01:45]

fdegans@chromium.org changed reviewers:
+ finnur@chromium.org, thakis@chromium.org

[Fabrice (no longer in Chrome), 2015-03-16 11:01:46]

finnur@chromium.org: Please review changes in extensions/
thakis@chromium.org: Please review changes in chrome/

Thanks for the quick reviews!
Owners, the only non-mechanical changes in this CL are in:
chrome/browser/tab_contents/navigation_metrics_recorder.cc
extensions/browser/guest_view/guest_view_base.cc

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3831: SetIsLoading(false,
true, NULL);
On 2015/03/14 00:01:04, nasko wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1008913002/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:3939: SetIsLoading(true,
to_different_document, NULL);
On 2015/03/14 00:01:04, nasko wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/1008913002/diff/20001/content/test/test_web_c...
File content/test/test_web_contents.cc (right):

https://codereview.chromium.org/1008913002/diff/20001/content/test/test_web_c...
content/test/test_web_contents.cc:142: SetIsLoading(value, true, NULL);
On 2015/03/14 00:01:04, nasko wrote:
> nit: nullptr

Done.

[Fabrice (no longer in Chrome), 2015-03-16 11:56:13]

https://codereview.chromium.org/1008913002/diff/40001/extensions/browser/gues...
File extensions/browser/guest_view/guest_view_base.cc (left):

https://codereview.chromium.org/1008913002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/guest_view_base.cc:522: if
(IsPreferredSizeModeEnabled()) {
On 2015/03/14 04:25:02, Fady Samuel wrote:
> nit: Could you please get rid of these unnecessary braces while you're at it?
> Thanks!

Done.

[Finnur, 2015-03-16 15:27:43]

Looking. In the meantime, is there a bug for this initiative?

[Finnur, 2015-03-16 15:29:19]

extensions/ LGTM

[Fabrice (no longer in Chrome), 2015-03-16 15:42:34]

On 2015/03/16 15:27:43, Finnur wrote:
> Looking. In the meantime, is there a bug for this initiative?

I added some more context, I have another CL that is dependent on that one. This
is mostly cleanup.

[nasko, 2015-03-16 16:25:10]

On 2015/03/16 15:42:34, Fabrice wrote:
> On 2015/03/16 15:27:43, Finnur wrote:
> > Looking. In the meantime, is there a bug for this initiative?
> 
> I added some more context, I have another CL that is dependent on that one.
This
> is mostly cleanup.

Let's add 450799 to the bug list, which is an overall bug tracking the
WebContentsObserver API cleanup.

[Fabrice (no longer in Chrome), 2015-03-18 13:29:46]

On 2015/03/16 16:25:10, nasko wrote:
> Let's add 450799 to the bug list, which is an overall bug tracking the
> WebContentsObserver API cleanup.

Done.
thakis, PTAL

[nasko, 2015-03-18 17:42:36]

Thanks for taking care of this Fabrice! It is a nice cleanup.

LGTM

[Nico, 2015-03-19 04:41:18]

chrome lgtm

[Fabrice (no longer in Chrome), 2015-03-19 09:49:04]

The CQ bit was checked by fdegans@chromium.org

[Fabrice (no longer in Chrome), 2015-03-19 09:49:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1008913002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-19 09:49:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008913002/100001

[commit-bot: I haz the power, 2015-03-19 09:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 09:55:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fabrice (no longer in Chrome), 2015-03-19 10:03:18]

The CQ bit was checked by fdegans@chromium.org

[Fabrice (no longer in Chrome), 2015-03-19 10:03:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, thakis@chromium.org, nasko@chromium.org,
finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1008913002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-19 10:03:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008913002/120001

[commit-bot: I haz the power, 2015-03-19 11:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-19 11:36:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Fabrice (no longer in Chrome), 2015-03-19 12:07:18]

The CQ bit was checked by fdegans@chromium.org

[commit-bot: I haz the power, 2015-03-19 12:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1008913002/120001

[commit-bot: I haz the power, 2015-03-19 12:52:34]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-03-19 12:54:07]

Patchset 7 (id:??) landed as
https://crrev.com/6ce28f57d686337e99099a7a97354f45d22ca2f6
Cr-Commit-Position: refs/heads/master@{#321341}