Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/browser/ui/tab_contents/core_tab_helper.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/core_tab_helper.h" 5 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 if (!guest_manager) 173 if (!guest_manager)
174 return false; 174 return false;
175 return guest_manager->ForEachGuest( 175 return guest_manager->ForEachGuest(
176 source, base::Bind(&CoreTabHelper::GetStatusTextForWebContents, 176 source, base::Bind(&CoreTabHelper::GetStatusTextForWebContents,
177 status_text)); 177 status_text));
178 } 178 }
179 179
180 //////////////////////////////////////////////////////////////////////////////// 180 ////////////////////////////////////////////////////////////////////////////////
181 // WebContentsObserver overrides 181 // WebContentsObserver overrides
182 182
183 void CoreTabHelper::DidStartLoading(content::RenderViewHost* render_view_host) { 183 void CoreTabHelper::DidStartLoading() {
184 UpdateContentRestrictions(0); 184 UpdateContentRestrictions(0);
185 } 185 }
186 186
187 void CoreTabHelper::WasShown() { 187 void CoreTabHelper::WasShown() {
188 web_cache::WebCacheManager::GetInstance()->ObserveActivity( 188 web_cache::WebCacheManager::GetInstance()->ObserveActivity(
189 web_contents()->GetRenderProcessHost()->GetID()); 189 web_contents()->GetRenderProcessHost()->GetID());
190 } 190 }
191 191
192 void CoreTabHelper::WebContentsDestroyed() { 192 void CoreTabHelper::WebContentsDestroyed() {
193 // OnCloseStarted isn't called in unit tests. 193 // OnCloseStarted isn't called in unit tests.
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 DCHECK(!content_type.empty()); 282 DCHECK(!content_type.empty());
283 open_url_params.uses_post = true; 283 open_url_params.uses_post = true;
284 open_url_params.browser_initiated_post_data = 284 open_url_params.browser_initiated_post_data =
285 base::RefCountedString::TakeString(post_data); 285 base::RefCountedString::TakeString(post_data);
286 open_url_params.extra_headers += base::StringPrintf( 286 open_url_params.extra_headers += base::StringPrintf(
287 "%s: %s\r\n", net::HttpRequestHeaders::kContentType, 287 "%s: %s\r\n", net::HttpRequestHeaders::kContentType,
288 content_type.c_str()); 288 content_type.c_str());
289 } 289 }
290 web_contents()->OpenURL(open_url_params); 290 web_contents()->OpenURL(open_url_params);
291 } 291 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698