chrome/browser/captive_portal/captive_portal_tab_helper.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper.h ('k') | chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_helper.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.cc b/chrome/browser/captive_portal/captive_portal_tab_helper.cc

index ec60bea87e921fb0d5aefb783fab4a28402051be..a8479f74ea1aede5e07e6782f585a3ade5fef882 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.cc

@@ -146,8 +146,7 @@ void CaptivePortalTabHelper::DidFailProvisionalLoad(

pending_error_code_ = error_code;

}

-void CaptivePortalTabHelper::DidStopLoading(

- content::RenderViewHost* render_view_host) {

+void CaptivePortalTabHelper::DidStopLoading() {

DCHECK(CalledOnValidThread());

login_detector_->OnStoppedLoading();