Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: content/public/test/test_navigation_observer.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/test/test_web_contents.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/test/test_navigation_observer.h" 5 #include "content/public/test/test_navigation_observer.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 20 matching lines...) Expand all
31 } 31 }
32 32
33 void DidAttachInterstitialPage() override { 33 void DidAttachInterstitialPage() override {
34 parent_->OnDidAttachInterstitialPage(web_contents()); 34 parent_->OnDidAttachInterstitialPage(web_contents());
35 } 35 }
36 36
37 void WebContentsDestroyed() override { 37 void WebContentsDestroyed() override {
38 parent_->OnWebContentsDestroyed(this, web_contents()); 38 parent_->OnWebContentsDestroyed(this, web_contents());
39 } 39 }
40 40
41 void DidStartLoading(RenderViewHost* render_view_host) override { 41 void DidStartLoading() override {
42 parent_->OnDidStartLoading(web_contents()); 42 parent_->OnDidStartLoading(web_contents());
43 } 43 }
44 44
45 void DidStopLoading(RenderViewHost* render_view_host) override { 45 void DidStopLoading() override {
46 parent_->OnDidStopLoading(web_contents()); 46 parent_->OnDidStopLoading(web_contents());
47 } 47 }
48 48
49 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host, 49 void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
50 const GURL& validated_url, 50 const GURL& validated_url,
51 bool is_error_page, 51 bool is_error_page,
52 bool is_iframe_srcdoc) override { 52 bool is_iframe_srcdoc) override {
53 parent_->OnDidStartProvisionalLoadForFrame( 53 parent_->OnDidStartProvisionalLoadForFrame(
54 render_frame_host, validated_url, is_error_page, is_iframe_srcdoc); 54 render_frame_host, validated_url, is_error_page, is_iframe_srcdoc);
55 } 55 }
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 void TestNavigationObserver::OnDidCommitProvisionalLoadForFrame( 191 void TestNavigationObserver::OnDidCommitProvisionalLoadForFrame(
192 RenderFrameHost* render_frame_host, 192 RenderFrameHost* render_frame_host,
193 const GURL& url, 193 const GURL& url,
194 ui::PageTransition transition_type) { 194 ui::PageTransition transition_type) {
195 last_navigation_url_ = url; 195 last_navigation_url_ = url;
196 last_navigation_succeeded_ = true; 196 last_navigation_succeeded_ = true;
197 } 197 }
198 198
199 } // namespace content 199 } // namespace content
OLDNEW
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/test/test_web_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698