content/browser/frame_host/navigation_controller_impl_browsertest.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_delegate.h ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

index 66646f7b60b19f0da05748a5d1bd3982bc95de55..6f54e00f1e96155094ac5adcfb32d3f6fd7f003b 100644

--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc

@@ -289,7 +289,7 @@ class FrameNavigateParamsCapturer : public WebContentsObserver {

message_loop_runner_->Quit();

}

- void DidStopLoading(RenderViewHost* render_view_host) override {

+ void DidStopLoading() override {

if (!navigations_remaining_)

message_loop_runner_->Quit();

}

@@ -359,9 +359,7 @@ class LoadCommittedCapturer : public WebContentsObserver {

message_loop_runner_->Quit();

}

- void DidStopLoading(RenderViewHost* render_view_host) override {

- message_loop_runner_->Quit();

- }

+ void DidStopLoading() override { message_loop_runner_->Quit(); }

// The id of the FrameTreeNode whose navigations to observe.

int frame_tree_node_id_;