extensions/browser/extension_host.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_host.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/extension_host.h

diff --git a/extensions/browser/extension_host.h b/extensions/browser/extension_host.h

index 83d3f1198d3322a2e2ad496284181c232e342c02..07f0c62b033277f3d9acc3e8e091a6df0cce777e 100644

--- a/extensions/browser/extension_host.h

+++ b/extensions/browser/extension_host.h

@@ -103,8 +103,8 @@ class ExtensionHost : public DeferredStartRenderHost,

void RenderViewReady() override;

void RenderProcessGone(base::TerminationStatus status) override;

void DocumentAvailableInMainFrame() override;

- void DidStartLoading(content::RenderViewHost* render_view_host) override;

- void DidStopLoading(content::RenderViewHost* render_view_host) override;

+ void DidStartLoading() override;

+ void DidStopLoading() override;

// content::WebContentsDelegate:

content::JavaScriptDialogManager* GetJavaScriptDialogManager(

« no previous file with comments | « content/test/test_web_contents.cc ('k') | extensions/browser/extension_host.cc » ('j') | no next file with comments »