content/browser/web_contents/aura/overscroll_navigation_overlay.cc - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_navigation_overlay.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_navigation_overlay.cc

diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

index a96b0d27ed66cd46912ebc7d55fdee0feb5e9f9c..c0c4a41a09bd5d71e102296e40d713ed2eae7a08 100644

--- a/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay.cc

@@ -304,7 +304,7 @@ void OverscrollNavigationOverlay::DidFirstVisuallyNonEmptyPaint() {

}

-void OverscrollNavigationOverlay::DidStopLoading(RenderViewHost* host) {

+void OverscrollNavigationOverlay::DidStopLoading() {

// Don't compare URLs in this case - it's possible they won't match if

// a gesture-nav initiated navigation was interrupted by some other in-site

// navigation ((e.g., from a script, or from a bookmark).