content/browser/frame_host/navigation_controller_delegate.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_delegate.h

diff --git a/content/browser/frame_host/navigation_controller_delegate.h b/content/browser/frame_host/navigation_controller_delegate.h

index 90fd4d33486e1d53af751157415acb05b2cf1b48..e578a84e9126608e98a4a6cdd54562e5bcfdecbf 100644

--- a/content/browser/frame_host/navigation_controller_delegate.h

+++ b/content/browser/frame_host/navigation_controller_delegate.h

@@ -71,8 +71,7 @@ class NavigationControllerDelegate {

virtual void AttachInterstitialPage(

InterstitialPageImpl* interstitial_page) = 0;

virtual void DetachInterstitialPage() = 0;

- virtual void SetIsLoading(RenderViewHost* render_view_host,

- bool is_loading,

+ virtual void SetIsLoading(bool is_loading,

bool to_different_document,

LoadNotificationDetails* details) = 0;

};