chrome/browser/printing/print_view_manager_base.h - Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_view_manager_base.h

diff --git a/chrome/browser/printing/print_view_manager_base.h b/chrome/browser/printing/print_view_manager_base.h

index c5800136710fb8d4d19dc2f10f7865dbe93d036a..6c202e5eb3e1494031234645b44f80e9f659f132 100644

--- a/chrome/browser/printing/print_view_manager_base.h

+++ b/chrome/browser/printing/print_view_manager_base.h

@@ -70,7 +70,7 @@ class PrintViewManagerBase : public content::NotificationObserver,

const content::NotificationDetails& details) override;

// content::WebContentsObserver implementation.

- void DidStartLoading(content::RenderViewHost* render_view_host) override;

+ void DidStartLoading() override;

// Cancels the print job.

void NavigationStopped() override;

« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.cc ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »