Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/prerender/prerender_tab_helper.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_tab_helper.h" 5 #include "chrome/browser/prerender/prerender_tab_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 10 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 93 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
94 if (!prerender_manager) 94 if (!prerender_manager)
95 return; 95 return;
96 if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL)) 96 if (prerender_manager->IsWebContentsPrerendering(web_contents(), NULL))
97 return; 97 return;
98 prerender_manager->RecordNavigation(validated_url); 98 prerender_manager->RecordNavigation(validated_url);
99 ReportTabHelperURLSeenToLocalPredictor(prerender_manager, validated_url, 99 ReportTabHelperURLSeenToLocalPredictor(prerender_manager, validated_url,
100 web_contents()); 100 web_contents());
101 } 101 }
102 102
103 void PrerenderTabHelper::DidStopLoading( 103 void PrerenderTabHelper::DidStopLoading() {
104 content::RenderViewHost* render_view_host) {
105 // Compute the PPLT metric and report it in a histogram, if needed. If the 104 // Compute the PPLT metric and report it in a histogram, if needed. If the
106 // page is still prerendering, record the not swapped in page load time 105 // page is still prerendering, record the not swapped in page load time
107 // instead. 106 // instead.
108 if (!pplt_load_start_.is_null()) { 107 if (!pplt_load_start_.is_null()) {
109 base::TimeTicks now = base::TimeTicks::Now(); 108 base::TimeTicks now = base::TimeTicks::Now();
110 if (IsPrerendering()) { 109 if (IsPrerendering()) {
111 PrerenderManager* prerender_manager = MaybeGetPrerenderManager(); 110 PrerenderManager* prerender_manager = MaybeGetPrerenderManager();
112 if (prerender_manager) { 111 if (prerender_manager) {
113 prerender_manager->RecordPageLoadTimeNotSwappedIn( 112 prerender_manager->RecordPageLoadTimeNotSwappedIn(
114 origin_, now - pplt_load_start_, url_); 113 origin_, now - pplt_load_start_, url_);
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 prerender_manager->RecordPerceivedPageLoadTime( 265 prerender_manager->RecordPerceivedPageLoadTime(
267 origin_, navigation_type_, perceived_page_load_time, 266 origin_, navigation_type_, perceived_page_load_time,
268 fraction_plt_elapsed_at_swap_in, url_); 267 fraction_plt_elapsed_at_swap_in, url_);
269 268
270 // Reset state for the next navigation. 269 // Reset state for the next navigation.
271 navigation_type_ = NAVIGATION_TYPE_NORMAL; 270 navigation_type_ = NAVIGATION_TYPE_NORMAL;
272 origin_ = ORIGIN_NONE; 271 origin_ = ORIGIN_NONE;
273 } 272 }
274 273
275 } // namespace prerender 274 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_tab_helper.h ('k') | chrome/browser/printing/print_view_manager_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698