Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: content/public/browser/web_contents_observer.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include "base/process/kill.h" 8 #include "base/process/kill.h"
9 #include "base/process/process_handle.h" 9 #include "base/process/process_handle.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 const Referrer& referrer, 237 const Referrer& referrer,
238 WindowOpenDisposition disposition, 238 WindowOpenDisposition disposition,
239 ui::PageTransition transition) {} 239 ui::PageTransition transition) {}
240 240
241 // This method is invoked when the renderer process has completed its first 241 // This method is invoked when the renderer process has completed its first
242 // paint after a non-empty layout. 242 // paint after a non-empty layout.
243 virtual void DidFirstVisuallyNonEmptyPaint() {} 243 virtual void DidFirstVisuallyNonEmptyPaint() {}
244 244
245 // These two methods correspond to the points in time when the spinner of the 245 // These two methods correspond to the points in time when the spinner of the
246 // tab starts and stops spinning. 246 // tab starts and stops spinning.
247 virtual void DidStartLoading(RenderViewHost* render_view_host) {} 247 virtual void DidStartLoading() {}
248 virtual void DidStopLoading(RenderViewHost* render_view_host) {} 248 virtual void DidStopLoading() {}
249 249
250 // When WebContents::Stop() is called, the WebContents stops loading and then 250 // When WebContents::Stop() is called, the WebContents stops loading and then
251 // invokes this method. If there are ongoing navigations, their respective 251 // invokes this method. If there are ongoing navigations, their respective
252 // failure methods will also be invoked. 252 // failure methods will also be invoked.
253 virtual void NavigationStopped() {} 253 virtual void NavigationStopped() {}
254 254
255 // This indicates that the next navigation was triggered by a user gesture. 255 // This indicates that the next navigation was triggered by a user gesture.
256 virtual void DidGetUserGesture() {} 256 virtual void DidGetUserGesture() {}
257 257
258 // This method is invoked when a RenderViewHost of this WebContents was 258 // This method is invoked when a RenderViewHost of this WebContents was
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 void ResetWebContents(); 377 void ResetWebContents();
378 378
379 WebContentsImpl* web_contents_; 379 WebContentsImpl* web_contents_;
380 380
381 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver); 381 DISALLOW_COPY_AND_ASSIGN(WebContentsObserver);
382 }; 382 };
383 383
384 } // namespace content 384 } // namespace content
385 385
386 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_ 386 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_OBSERVER_H_
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl_unittest.cc ('k') | content/public/test/browser_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698