Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
index 962ba284d9a6b7c55b219f202d7768a3ca51073f..cbdf99192bdbea08988791fcd3d6cdbce72a7365 100644
--- a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
+++ b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc
@@ -245,12 +245,12 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {
TEST_F(CaptivePortalTabHelperTest, HttpSuccess) {
SimulateSuccess(GURL(kHttpUrl), render_view_host1());
- tab_helper().DidStopLoading(render_view_host1());
+ tab_helper().DidStopLoading();
}
TEST_F(CaptivePortalTabHelperTest, HttpTimeout) {
SimulateTimeout(GURL(kHttpUrl), render_view_host1());
- tab_helper().DidStopLoading(render_view_host1());
+ tab_helper().DidStopLoading();
}
// Same as above, but simulates what happens when the Link Doctor is enabled,
@@ -268,12 +268,12 @@ TEST_F(CaptivePortalTabHelperTest, HttpTimeoutLinkDoctor) {
tab_helper().DidCommitProvisionalLoadForFrame(main_render_frame1(),
GURL(kErrorPageUrl),
ui::PAGE_TRANSITION_LINK);
- tab_helper().DidStopLoading(render_view_host1());
+ tab_helper().DidStopLoading();
}
TEST_F(CaptivePortalTabHelperTest, HttpsSuccess) {
SimulateSuccess(GURL(kHttpsUrl), render_view_host1());
- tab_helper().DidStopLoading(render_view_host1());
+ tab_helper().DidStopLoading();
EXPECT_FALSE(tab_helper().IsLoginTab());
}
« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper.cc ('k') | chrome/browser/extensions/api/identity/web_auth_flow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698