Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/background/background_contents.h

Issue 1008913002: Remove RenderViewHost parameter from WebContentsObserver::Did{Start|Stop}Loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
6 #define CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 6 #define CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void AddNewContents(content::WebContents* source, 74 void AddNewContents(content::WebContents* source,
75 content::WebContents* new_contents, 75 content::WebContents* new_contents,
76 WindowOpenDisposition disposition, 76 WindowOpenDisposition disposition,
77 const gfx::Rect& initial_rect, 77 const gfx::Rect& initial_rect,
78 bool user_gesture, 78 bool user_gesture,
79 bool* was_blocked) override; 79 bool* was_blocked) override;
80 bool IsNeverVisible(content::WebContents* web_contents) override; 80 bool IsNeverVisible(content::WebContents* web_contents) override;
81 81
82 // content::WebContentsObserver implementation: 82 // content::WebContentsObserver implementation:
83 void RenderProcessGone(base::TerminationStatus status) override; 83 void RenderProcessGone(base::TerminationStatus status) override;
84 void DidStartLoading(content::RenderViewHost* render_view_host) override; 84 void DidStartLoading() override;
85 void DidStopLoading(content::RenderViewHost* render_view_host) override; 85 void DidStopLoading() override;
86 86
87 // content::NotificationObserver 87 // content::NotificationObserver
88 void Observe(int type, 88 void Observe(int type,
89 const content::NotificationSource& source, 89 const content::NotificationSource& source,
90 const content::NotificationDetails& details) override; 90 const content::NotificationDetails& details) override;
91 91
92 protected: 92 protected:
93 // Exposed for testing. 93 // Exposed for testing.
94 BackgroundContents(); 94 BackgroundContents();
95 95
(...skipping 29 matching lines...) Expand all
125 BackgroundContents* contents; 125 BackgroundContents* contents;
126 126
127 // The name of the parent frame for these contents. 127 // The name of the parent frame for these contents.
128 const base::string16& frame_name; 128 const base::string16& frame_name;
129 129
130 // The ID of the parent application (if any). 130 // The ID of the parent application (if any).
131 const base::string16& application_id; 131 const base::string16& application_id;
132 }; 132 };
133 133
134 #endif // CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_ 134 #endif // CHROME_BROWSER_BACKGROUND_BACKGROUND_CONTENTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698