Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed)

Created:
6 years, 9 months ago by Johnni Winther
Modified:
6 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove cancel and make crash exit with code 253. BUG=http://dartbug.com/17557 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=34238

Patch Set 1 #

Patch Set 2 : Make internalError throw. #

Patch Set 3 : Remove reportInternalError #

Total comments: 8

Patch Set 4 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -433 lines) Patch
M sdk/lib/_internal/compiler/implementation/apiimpl.dart View 1 2 3 5 chunks +12 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 2 3 4 chunks +5 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 10 chunks +24 lines, -58 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2jslib.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart View 1 2 3 1 chunk +5 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dump_info.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 3 6 chunks +16 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/inferrer_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_pickler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart View 5 chunks +9 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js/printer.dart View 1 2 3 4 chunks +6 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 2 3 3 chunks +7 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart View 1 2 3 2 chunks +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 2 3 5 chunks +40 lines, -34 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_instance_mirrors.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart View 1 2 3 4 chunks +10 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 2 3 10 chunks +22 lines, -19 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ordered_typeset.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/class_members.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 9 chunks +16 lines, -22 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/signatures.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 1 2 3 19 chunks +53 lines, -48 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 3 31 chunks +62 lines, -59 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 2 3 5 chunks +7 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/string_validator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 2 3 6 chunks +10 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/util/util.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/world.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 2 3 chunks +17 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 chunk +2 lines, -9 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +7 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
6 years, 9 months ago (2014-03-20 08:44:08 UTC) #1
Johnni Winther
Ready for review.
6 years, 9 months ago (2014-03-20 11:02:14 UTC) #2
karlklose
LGTM, however I prefer having the 'spannable' as second argument because it makes it easier ...
6 years, 9 months ago (2014-03-21 08:39:39 UTC) #3
Johnni Winther
https://codereview.chromium.org/206193002/diff/40001/sdk/lib/_internal/compiler/implementation/scanner/listener.dart File sdk/lib/_internal/compiler/implementation/scanner/listener.dart (right): https://codereview.chromium.org/206193002/diff/40001/sdk/lib/_internal/compiler/implementation/scanner/listener.dart#newcode653 sdk/lib/_internal/compiler/implementation/scanner/listener.dart:653: final DiagnosticListener listener; On 2014/03/21 08:39:39, karlklose wrote: > ...
6 years, 9 months ago (2014-03-21 09:39:22 UTC) #4
Johnni Winther
6 years, 9 months ago (2014-03-21 09:46:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r34238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698