Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: sdk/lib/_internal/compiler/implementation/typechecker.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/typechecker.dart
diff --git a/sdk/lib/_internal/compiler/implementation/typechecker.dart b/sdk/lib/_internal/compiler/implementation/typechecker.dart
index 401645fcd287d1d51df7a2f0f5fe1d4e435fe691..c52c9fe1099e98ac560df201a32fb26e6779f517 100644
--- a/sdk/lib/_internal/compiler/implementation/typechecker.dart
+++ b/sdk/lib/_internal/compiler/implementation/typechecker.dart
@@ -367,11 +367,11 @@ class TypeCheckerVisitor extends Visitor<DartType> {
/// a field and not to a setter.
DartType analyze(Node node, {bool inInitializer: false}) {
if (node == null) {
- final String error = 'unexpected node: null';
+ final String error = 'Unexpected node: null';
if (lastSeenNode != null) {
- compiler.internalError(error, node: lastSeenNode);
+ compiler.internalError(lastSeenNode, error);
} else {
- compiler.cancel(error);
+ compiler.internalError(elements.currentElement, error);
}
} else {
lastSeenNode = node;
@@ -381,7 +381,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
DartType result = node.accept(this);
analyzingInitializer = previouslyInitializer;
if (result == null) {
- compiler.internalError('type is null', node: node);
+ compiler.internalError(node, 'Type is null.');
}
return result;
}
@@ -982,8 +982,8 @@ class TypeCheckerVisitor extends Visitor<DartType> {
} else if (element.isGetter() || element.isSetter()) {
return createResolvedAccess(node, name, element);
} else {
- compiler.internalErrorOnElement(
- element, 'unexpected element kind ${element.kind}');
+ compiler.internalError(element,
+ 'Unexpected element kind ${element.kind}.');
return null;
}
}
@@ -1015,8 +1015,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
computeAccess(node, name, element, memberKind,
lookupClassMember: lookupClassMember).computeType(compiler);
if (type == null) {
- compiler.internalError('type is null on access of $name on $node',
- node: node);
+ compiler.internalError(node, 'Type is null on access of $name on $node.');
}
return type;
}
@@ -1412,8 +1411,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
case '<<=': operatorName = '<<'; break;
case '>>=': operatorName = '>>'; break;
default:
- compiler.internalError(
- 'Unexpected assignment operator $name', node: node);
+ compiler.internalError(node, 'Unexpected assignment operator $name.');
}
if (node.isIndex) {
// base[key] o= value for some operator o.
@@ -1746,8 +1744,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
}
visitNode(Node node) {
- compiler.internalError(
- 'Unexpected node ${node.getObjectDescription()} in the type checker.',
- node: node);
+ compiler.internalError(node,
+ 'Unexpected node ${node.getObjectDescription()} in the type checker.');
}
}

Powered by Google App Engine
This is Rietveld 408576698