sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart - Issue 206193002: Remove cancel and make crash exit with code 253.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

index 6111f230deb77c16b8eef001cc4cda43e62f08b8..c54fef85138277a98bd25e7ea44966eda217e481 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

@@ -151,10 +151,10 @@ class ContainerBuilder extends CodeEmitterHelper {

if (member.enclosingElement.isClosure()) {

ClosureClassElement cls = member.enclosingElement;

if (cls.supertype.element == compiler.boundClosureClass) {

- compiler.internalErrorOnElement(cls.methodElement, 'Bound closure1.');

+ compiler.internalError(cls.methodElement, 'Bound closure1.');

}

if (cls.methodElement.isInstanceMember()) {

- compiler.internalErrorOnElement(cls.methodElement, 'Bound closure2.');

+ compiler.internalError(cls.methodElement, 'Bound closure2.');

}

@@ -337,8 +337,8 @@ class ContainerBuilder extends CodeEmitterHelper {

member.isAccessor()) {

addMemberMethod(member, builder);

} else {

- compiler.internalErrorOnElement(

- member, 'unexpected kind: "${member.kind}"');

+ compiler.internalError(member,

+ 'Unexpected kind: "${member.kind}".');

}

if (member.isInstanceMember()) emitExtraAccessors(member, builder);

}