sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart - Issue 206193002: Remove cancel and make crash exit with code 253.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart ('k') | sdk/lib/_internal/compiler/implementation/library_loader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

index 43ec0dd49c784f93cedd3bae2bc65a4a0f64ac69..394ee95d1454aba10d058bd4418e8cb24109e4c1 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart

@@ -29,8 +29,7 @@ class MetadataEmitter extends CodeEmitterHelper {

MetadataAnnotation annotation = link.head;

Constant value = annotation.value;

if (value == null) {

- compiler.reportInternalError(annotation,

- MessageKind.GENERIC, {'text': 'Annotation value is null'});

+ compiler.internalError(annotation, 'Annotation value is null.');

} else {

metadata.add(task.constantReference(value));

}

@@ -61,8 +60,7 @@ class MetadataEmitter extends CodeEmitterHelper {

int reifyMetadata(MetadataAnnotation annotation) {

Constant value = annotation.value;

if (value == null) {

- compiler.reportInternalError(annotation,

- MessageKind.GENERIC, {'text': 'Annotation value is null'});

+ compiler.internalError(annotation, 'Annotation value is null.');

return -1;

}

return addGlobalMetadata(