sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart - Issue 206193002: Remove cancel and make crash exit with code 253.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

index c3b54b1ed7586d185cfa5c5c8e65bf4af89e7763..cd8f703106ae89a78f856cefe57a7ccff4382b42 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart

@@ -203,9 +203,8 @@ class ClassEmitter extends CodeEmitterHelper {

}

int code = getterCode + (setterCode << 2);

if (code == 0) {

- compiler.reportInternalError(

- field, MessageKind.GENERIC,

- {'text': 'Field code is 0 ($element/$field)'});

+ compiler.internalError(field,

+ 'Field code is 0 ($element/$field).');

} else {

fieldCode = FIELD_CODE_CHARACTERS[code - FIRST_FIELD_CODE];

}