sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart - Issue 206193002: Remove cancel and make crash exit with code 253.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

index a847d3efddfdca044a0fca8b5d4487d47e6f1e8a..9c467ba910bccf58f77f6ce7dc42587378c42425 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

@@ -73,8 +73,7 @@ class TypeVariableHandler {

for (TypeVariableType currentTypeVariable in cls.typeVariables) {

List<Constant> createArguments(FunctionElement constructor) {

if (constructor != typeVariableConstructor) {

- compiler.internalErrorOnElement(

- currentTypeVariable.element,

+ compiler.internalError(currentTypeVariable.element,

'Unexpected constructor $constructor');

}

Constant name = backend.constantSystem.createString(

@@ -103,11 +102,8 @@ class TypeVariableHandler {

typeVariableClass.ensureResolved(compiler);

Link constructors = typeVariableClass.constructors;

if (constructors.isEmpty && constructors.tail.isEmpty) {

- compiler.reportInternalError(

- typeVariableClass,

- MessageKind.GENERIC,

- {'text': "Class '$typeVariableClass' should only "

- "have one constructor"});

+ compiler.internalError(typeVariableClass,

+ "Class '$typeVariableClass' should only have one constructor");

}

typeVariableConstructor = typeVariableClass.constructors.head;

backend.enqueueInResolution(typeVariableConstructor,