Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
index 4cb149edd7b8f95897d4e1cb451f6d08157639f5..2f9f0145cab39c65c88f78db5cbe64ad7e36bc14 100644
--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart
@@ -742,8 +742,8 @@ class CodeEmitterTask extends CompilerTask {
if (cls.isUnnamedMixinApplication) return null;
return cls.name;
}
- throw compiler.internalErrorOnElement(
- element, 'Do not know how to reflect on this $element');
+ throw compiler.internalError(element,
+ 'Do not know how to reflect on this $element.');
}
String namedParametersAsReflectionNames(Selector selector) {
@@ -1421,7 +1421,8 @@ mainBuffer.add(r'''
elementDescriptors[library] = const {};
}
if (!pendingStatics.isEmpty) {
- compiler.internalError('Pending statics (see above).');
+ compiler.internalError(pendingStatics.first,
+ 'Pending statics (see above).');
}
mainBuffer.write('])$N');
@@ -1600,7 +1601,7 @@ if (typeof $printHelperName === "function") {
}
}
if (owner == null) {
- compiler.internalErrorOnElement(element, 'Owner is null');
+ compiler.internalError(element, 'Owner is null.');
}
return getElementDescriptorForOutputUnit(owner,
compiler.deferredLoadTask.outputUnitForElement(element));

Powered by Google App Engine
This is Rietveld 408576698