Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
diff --git a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
index b02a293ca13667ac770170d596209789721bf522..121fe5b45757a07ae96c40e480d2d9acefeed8dd 100644
--- a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
+++ b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
@@ -226,8 +226,7 @@ class ConstantHandler extends CompilerTask {
Constant getInitialValueFor(VariableElement element) {
Constant initialValue = initialVariableValues[element.declaration];
if (initialValue == null) {
- compiler.internalError("No initial value for given element",
- element: element);
+ compiler.internalError(element, "No initial value for given element.");
}
return initialValue;
}
@@ -502,7 +501,7 @@ class CompileTimeConstantEvaluator extends Visitor {
folded = constantSystem.bitNot.fold(receiverConstant);
break;
default:
- compiler.internalError("Unexpected operator.", node: op);
+ compiler.internalError(op, "Unexpected operator.");
break;
}
if (folded == null) return signalNotCompileTimeConstant(send);
@@ -848,7 +847,7 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
if (Elements.isLocal(element)) {
Constant constant = definitions[element];
if (constant == null) {
- compiler.internalError("Local variable without value", node: send);
+ compiler.internalError(send, "Local variable without value.");
}
return constant;
}
@@ -972,8 +971,8 @@ class ConstructorEvaluator extends CompileTimeConstantEvaluator {
FunctionElement targetConstructor =
superClass.lookupConstructor(selector);
if (targetConstructor == null) {
- compiler.internalError("no default constructor available",
- node: functionNode);
+ compiler.internalError(functionNode,
+ "No default constructor available.");
}
List<Constant> compiledArguments = evaluateArgumentsToConstructor(
functionNode, selector, const Link<Node>(), targetConstructor);
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/closure.dart ('k') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698