Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart b/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
index dd70c694d817c26fb816388419b51d884ebcd170..40d77b10f8f3cac4c9a58eddf7028691fd16458c 100644
--- a/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart
@@ -5,18 +5,17 @@
part of dart2js;
abstract class DiagnosticListener {
- // TODO(karlklose): replace cancel with better error reporting mechanism.
- void cancel(String reason, {node, token, instruction, element});
// TODO(karlklose): rename log to something like reportInfo.
void log(message);
- void internalErrorOnElement(Element element, String message);
- void internalError(String message,
- {Node node, Token token, HInstruction instruction,
- Element element});
+ void internalError(Spannable spannable, message);
SourceSpan spanFromSpannable(Spannable node);
+ /// Reports an error and terminates computation immediately.
+ void reportFatalError(Spannable node, MessageKind errorCode,
+ [Map arguments = const {}]);
+
void reportError(Spannable node, MessageKind errorCode,
[Map arguments = const {}]);

Powered by Google App Engine
This is Rietveld 408576698