Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart
index 37f542b2fbba60482484d32430f898d19d74a714..09703a6577541870f2c6154fe185db06f2996a75 100644
--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart
@@ -12,7 +12,11 @@ import '../resolution/resolution.dart' show Scope;
import '../dart2jslib.dart';
import '../dart_types.dart';
import '../tree/tree.dart';
-import '../util/util.dart' show Spannable, Link, LinkBuilder;
+import '../util/util.dart'
+ show Spannable,
+ Link,
+ LinkBuilder,
+ NO_LOCATION_SPANNABLE;
import '../util/characters.dart' show $CR, $LF;
import 'source_mirrors.dart';
@@ -131,8 +135,8 @@ abstract class Dart2JsDeclarationMirror extends Dart2JsMirror
}
return members;
}
- mirrorSystem.compiler.internalError(
- "Unexpected member type $element ${element.kind}");
+ mirrorSystem.compiler.internalError(element,
+ "Unexpected member type $element ${element.kind}.");
return null;
}
@@ -339,7 +343,8 @@ class Dart2JsMirrorSystem extends MirrorSystem {
return new Dart2JsTypedefMirror(this, type);
}
}
- compiler.internalError("Unexpected type $type of kind ${type.kind}");
+ compiler.internalError(type.element,
+ "Unexpected type $type of kind ${type.kind}.");
return null;
}
@@ -349,7 +354,7 @@ class Dart2JsMirrorSystem extends MirrorSystem {
} else if (element.isTypedef()) {
return new Dart2JsTypedefDeclarationMirror(this, element.thisType);
}
- compiler.internalError("Unexpected element $element");
+ compiler.internalError(element, "Unexpected element $element.");
return null;
}
}

Powered by Google App Engine
This is Rietveld 408576698