Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart b/sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart
index 075d0f1351e687a8c73e95e054074810ab74f3cc..20beec7949911113cb2c94d886d6cac2c297f12f 100644
--- a/sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart
+++ b/sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart
@@ -28,7 +28,7 @@ class Unpickler {
ByteData doubleData = new ByteData(8);
ConstantSystem get constantSystem => compiler.backend.constantSystem;
-
+
// A partially constructed expression is one that has a single 'hole' where
// there is an expression missing. Just like the IR builder, the unpickler
// represents such an expression by its root and by the 'current' expression
@@ -76,7 +76,8 @@ class Unpickler {
} else if (tag == Pickles.STRING_UTF8) {
return UTF8.decode(bytes);
} else {
- compiler.internalError("Unexpected string tag: $tag");
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ "Unexpected string tag: $tag");
return null;
}
}
@@ -142,7 +143,8 @@ class Unpickler {
current = null;
break;
default:
- compiler.internalError("Unexpected expression entry tag: $tag");
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ "Unexpected expression entry tag: $tag");
break;
}
}
@@ -231,7 +233,8 @@ class Unpickler {
case Pickles.CONST_NULL:
return constantSystem.createNull();
default:
- compiler.internalError("Unexpected constant tag: $tag");
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ "Unexpected constant tag: $tag");
return null;
}
}
@@ -248,7 +251,8 @@ class Unpickler {
return new ast.ConsDartString(
readDartString(readByte()), readDartString(readByte()));
default:
- compiler.internalError("Unexpected dart string tag: $tag");
+ compiler.internalError(NO_LOCATION_SPANNABLE,
+ "Unexpected dart string tag: $tag");
return null;
}
}

Powered by Google App Engine
This is Rietveld 408576698