sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart - Issue 206193002: Remove cancel and make crash exit with code 253.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

index 0f50edd027f808b8c564adf389abcdf6d9e0dd51..ad0e1ff37565b51b04264b0174d0bdae59aaa1d8 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

@@ -443,7 +443,7 @@ class NativeEmitter {

bool isSupertypeOfNativeClass(Element element) {

if (element.isTypeVariable()) {

- compiler.cancel("Is check for type variable", element: element);

+ compiler.internalError(element, "Is check for type variable.");

return false;

}

if (element.computeType(compiler).unalias(compiler) is FunctionType) {

@@ -453,7 +453,7 @@ class NativeEmitter {

}

if (!element.isClass()) {

- compiler.cancel("Is check does not handle element", element: element);

+ compiler.internalError(element, "Is check does not handle element.");

return false;

}