Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/signatures.dart

Issue 206193002: Remove cancel and make crash exit with code 253. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
diff --git a/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart b/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
index 10ddfe0b5c36564cfaa59eb56d8fcfa4a680a0a3..e56d0a34414ab016e0f6ec4940d5b8daed91017e 100644
--- a/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
+++ b/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart
@@ -46,26 +46,26 @@ class SignatureResolver extends MappingVisitor<ParameterElementX> {
ParameterElementX visitVariableDefinitions(VariableDefinitions node) {
Link<Node> definitions = node.definitions.nodes;
if (definitions.isEmpty) {
- cancel(node, 'internal error: no parameter definition');
+ internalError(node, 'no parameter definition');
return null;
}
if (!definitions.tail.isEmpty) {
- cancel(definitions.tail.head, 'internal error: extra definition');
+ internalError(definitions.tail.head, 'extra definition');
return null;
}
Node definition = definitions.head;
if (definition is NodeList) {
- cancel(node, 'optional parameters are not implemented');
+ internalError(node, 'optional parameters are not implemented');
}
if (node.modifiers.isConst()) {
- error(node, MessageKind.FORMAL_DECLARED_CONST);
+ compiler.reportError(node, MessageKind.FORMAL_DECLARED_CONST);
}
if (node.modifiers.isStatic()) {
- error(node, MessageKind.FORMAL_DECLARED_STATIC);
+ compiler.reportError(node, MessageKind.FORMAL_DECLARED_STATIC);
}
if (currentDefinitions != null) {
- cancel(node, 'function type parameters not supported');
+ internalError(node, 'function type parameters not supported');
}
currentDefinitions = node;
ParameterElementX element = definition.accept(this);
@@ -124,7 +124,7 @@ class SignatureResolver extends MappingVisitor<ParameterElementX> {
functionExpression.name.asIdentifier() != null) {
return functionExpression.name.asIdentifier();
} else {
- cancel(node,
+ internalError(node,
'internal error: unimplemented receiver on parameter send');
return null;
}

Powered by Google App Engine
This is Rietveld 408576698