Issue 7259019: Move base/values.h into the base namespace.

Issue 7259019: Move base/values.h into the base namespace. (Closed)

Created:
9 years, 5 months ago by dmazzoni

Modified:
9 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews, cbentzel+watch_chromium.org, tfarina, Erik does not do reviews, brettw-cc_chromium.org, kkania, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move base/values.h into the base namespace. This includes a cros DEPS roll with a minor change to that code since libcros also uses base/values.h. BUG=88666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92208

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1798 lines, -1265 lines)			Patch
M	base/json/json_reader.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/json/json_writer.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/value_conversions.h	View	1 2 3 4 5	1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/values.h	View	1 2 3 4 5	2 chunks	+20 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/accessibility_events.h	View	1 2 3 4 5	9 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_provider.h	View	1 2 3 4 5	4 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_json.h	View	1 2 3 4 5	5 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/automation/automation_provider_observers.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_util.h	View	1 2 3 4 5	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.h	View	1 2 3 4 5	34 chunks	+145 lines, -131 lines	0 comments	Download
M	chrome/browser/background/background_contents_service.h	View	1 2 3 4 5	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_codec.h	View	1 2 3 4 5	5 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1 2 3 4 5	9 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings.h	View	1 2 3 4 5	2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_provider.h	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/cros_settings_provider.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/customization_document.h	View	1 2 3 4 5	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/locale_change_guard.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/enterprise_enrollment_view.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/metrics_cros_settings_provider.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/network_message_observer.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/notifications/balloon_view_host.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.h	View	1 2 3 4 5	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_origin_identifier_value_map.h	View	1 2 3 4 5	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_policy_provider.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/download/download_util.h	View	1 2 3 4 5	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/enumerate_modules_model_win.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmark_helpers.h	View	1 2 3 4 5	1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmark_manager_api.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.h	View	1 2 3 4 5	4 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_browser_actions_api.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_content_settings_store.h	View	1 2 3 4 5	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_api.h	View	1 2 3 4 5	3 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_api.h	View	1 2 3 4 5	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_cookies_helpers.h	View	1 2 3 4 5	5 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_debugger_api.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function.h	View	1 2 3 4 5	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_history_api.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_input_ui_api.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_api.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_pref_value_map.h	View	1 2 3 4 5	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_preference_api.h	View	1 2 3 4 5	3 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 2 3 4 5	7 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_proxy_api.h	View	1 2 3 4 5	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_proxy_api_helpers.h	View	1 2 3 4 5	5 chunks	+30 lines, -24 lines	0 comments	Download
M	chrome/browser/extensions/extension_sidebar_api.h	View	1 2 3 4 5	10 chunks	+14 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/extension_tabs_module.h	View	1 2 3 4 5	1 chunk	+14 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/extension_tts_api_controller.h	View	1 2 3 4 5	4 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_tts_engine_api.h	View	1 2 3 4 5	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.h	View	1 2 3 4 5	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api.h	View	1 2 3 4 5	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.h	View	1 2 3 4 5	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.h	View	1 2 3 4 5	3 chunks	+21 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/external_extension_loader.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/external_extension_provider_impl.h	View	1 2 3 4 5	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/external_policy_extension_loader.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker.h	View	1 2 3 4 5	3 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_prefs.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/external_protocol/external_protocol_handler.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_content_settings_map.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/history/top_sites.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/external_process_importer_bridge.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/io_thread.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.h	View	1 2 3 4 5	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	1 2 3 4 5	3 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/net/predictor.h	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/net/predictor_api.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/net/referrer.h	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/net/service_providers_win.h	View	1 2 3 4 5	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/notifications/notifications_prefs_cache.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/plugin_updater.h	View	1 2 3 4 5	3 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_store_interface.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/prefs/command_line_pref_store.h	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/prefs/overlay_persistent_pref_store.h	View	1 2 3 4 5	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/prefs/pref_member.h	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/prefs/pref_model_associator.h	View	1 2 3 4 5	3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/prefs/pref_service.h	View	1 2 3 4 5	10 chunks	+18 lines, -15 lines	0 comments	Download
M	chrome/browser/prefs/pref_value_map.h	View	1 2 3 4 5	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/proxy_config_dictionary.h	View	1 2 3 4 5	3 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/prefs/scoped_user_pref_update.h	View	1 2 3 4 5	4 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/prefs/testing_pref_store.h	View	1 2 3 4 5	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/prefs/value_map_pref_store.h	View	1 2 3 4 5	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_history.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_manager.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_setup_flow.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud_internal.h	View	1 2 3 4 5	4 chunks	+13 lines, -8 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_gtk.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_job_worker.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/printer_query.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/printing_message_filter.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.h	View	1 2 3 4 5	2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncapi.h	View	1 2 3 4 5	4 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/js_test_util.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/protocol/proto_value_conversions.h	View	1 2 3 4 5	2 chunks	+22 lines, -20 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state.h	View	1 2 3 4 5	6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow_handler.h	View	1 2 3 4 5	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 2 3 4 5	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type.h	View	1 2 3 4 5	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type_payload_map.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 2 3 4 5	4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_id.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.h	View	1 2 3 4 5	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/translate/translate_prefs.h	View	1 2 3 4 5	2 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_url_data_manager.h	View	1 2 3 4 5	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h	View	1 2 3 4 5	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/login_ui.h	View	1 2 3 4 5	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/login_ui_helpers.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_screen_handler.h	View	1 2 3 4 5	3 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.h	View	1 2 3 4 5	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View	1 2 3 4 5	3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/update_screen_handler.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/collected_cookies_ui_delegate.h	View	1 2 3 4 5	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/constrained_html_ui.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/cookies_tree_model_adapter.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/cookies_tree_model_util.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/downloads_dom_handler.h	View	1 2 3 4 5	3 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/history2_ui.h	View	1 2 3 4 5	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/history_ui.h	View	1 2 3 4 5	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_ui.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/media_internals/media_internals_handler.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/media_internals/media_internals_handler.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/net_internals_ui.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/new_profile_handler.h	View	1 2 3 4 5	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.h	View	1 2 3 4 5	2 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/favicon_webui_handler.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/most_visited_handler.h	View	1 2 3 4 5	3 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/shown_sections_handler.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/about_page_handler.h	View	1 2 3 4 5	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.h	View	1 2 3 4 5	3 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/options/certificate_manager_handler.h	View	1 2 3 4 5	7 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/accounts_options_handler.h	View	1 2 3 4 5	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h	View	1 2 3 4 5	2 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h	View	1 2 3 4 5	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.h	View	1 2 3 4 5	3 chunks	+36 lines, -36 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/language_chewing_handler.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/language_mozc_handler.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/language_options_util.h	View	1 2 3 4 5	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/proxy_handler.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/stats_options_handler.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_options_handler.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/system_settings_provider.h	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/cookies_view_handler.h	View	1 2 3 4 5	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options/extension_settings_handler.h	View	1 2 3 4 5	7 chunks	+27 lines, -24 lines	0 comments	Download
M	chrome/browser/ui/webui/options/font_settings_utils.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/handler_options_handler.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/import_data_handler.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/language_options_handler.h	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/language_options_handler_common.h	View	1 2 3 4 5	5 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui.h	View	1 2 3 4 5	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/search_engine_manager_handler.h	View	1 2 3 4 5	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/options/stop_syncing_handler.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/sync_setup_handler.h	View	1 2 3 4 5	2 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	1 2 3 4 5	2 chunks	+17 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_internals_ui.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/task_manager_handler.h	View	1 2 3 4 5	2 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/textfields_ui.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/web_ui_browsertest.h	View	1 2 3 4 5	4 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/web_resource/gpu_blacklist_updater.h	View	1 2 3 4 5	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.h	View	1 2 3 4 5	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/web_resource/web_resource_service.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	1 2 3 4 5	12 chunks	+43 lines, -35 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.h	View	1 2 3 4 5	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/extension_message_bundle.h	View	1 2 3 4 5	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_permission_set.h	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.h	View	1 2 3 4 5	4 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/common/json_pref_store.h	View	1 2 3 4 5	4 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/common/json_schema_validator.h	View	1 2 3 4 5	6 chunks	+22 lines, -16 lines	0 comments	Download
M	chrome/common/json_schema_validator_unittest_base.h	View	1 2 3 4 5	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/common/jstemplate_builder.h	View	1 2 3 4 5	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/common/net/gaia/google_service_auth_error.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/persistent_pref_store.h	View	1 2 3 4 5	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/pref_store.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/web_apps.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/web_resource/web_resource_unpacker.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/installer/setup/install.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/installer/util/google_chrome_distribution_dummy.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.h	View	1 2 3 4 5	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/profile_import/profile_import_thread.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/event_bindings.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/renderer/localized_error.h	View	1 2 3 4 5	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/renderer/print_web_view_helper.h	View	1 2 3 4 5	4 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_helpers.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_url_fetcher.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/cloud_print/job_status_updater.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/job_status_updater.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/cloud_print/print_system.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_dummy.cc	View	1 2 3 4 5	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.h	View	1 2 3 4 5	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/service/service_process_prefs.h	View	1 2 3 4 5	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/test/automation/automation_json_requests.h	View	1 2 3 4 5	4 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/test/automation/tab_proxy.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/test/live_sync/live_preferences_sync_test.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ui_test.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/test/ui_test_utils.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/values_test_util.h	View	1 2 3 4 5	2 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/test/webdriver/automation.h	View	1 2 3 4 5	3 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/test/webdriver/commands/alert_commands.h	View	1 2 3 4 5	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/test/webdriver/commands/cookie_commands.h	View	1 2 3 4 5	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/test/webdriver/commands/execute_async_script_command.h	View	1 2 3 4 5	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/webdriver/commands/mouse_commands.h	View	1 2 3 4 5	10 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/test/webdriver/commands/screenshot_command.h	View	1 2 3 4 5	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/webdriver/commands/set_timeout_commands.h	View	1 2 3 4 5	5 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/test/webdriver/commands/source_command.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/webdriver/commands/target_locator_commands.h	View	1 2 3 4 5	6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/test/webdriver/commands/webdriver_command.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/webdriver/commands/webelement_commands.h	View	1 2 3 4 5	17 chunks	+18 lines, -16 lines	0 comments	Download
M	chrome/test/webdriver/dispatch.h	View	1 2 3 4 5	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/test/webdriver/session.h	View	1 2 3 4 5	6 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/test/webdriver/utility_functions.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/webdriver/utility_functions.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/webdriver/web_element_id.h	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/debugger/debugger_host.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/debugger/debugger_remote_service.h	View	1 2 3 4 5	5 chunks	+11 lines, -8 lines	0 comments	Download
M	content/browser/debugger/devtools_remote_service.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/debugger/devtools_window.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/debugger/extension_ports_remote_service.h	View	1 2 3 4 5	3 chunks	+12 lines, -7 lines	0 comments	Download
M	content/browser/font_list_async.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/gpu/gpu_blacklist.h	View	1 2 3 4 5	6 chunks	+13 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1 2 3 4 5	3 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/webui/generic_handler.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/webui/web_ui.h	View	1 2 3 4 5	7 chunks	+24 lines, -20 lines	0 comments	Download
M	content/common/font_list.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/common/view_messages.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/v8_value_converter.h	View	1 2 3 4 5	2 chunks	+13 lines, -11 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View	1 2 3 4 5	2 chunks	+6 lines, -6 lines	0 comments	Download
M	net/base/address_list_net_log_param.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	net/base/crl_filter.h	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/base/net_log.h	View	1 2 3 4 5	7 chunks	+13 lines, -11 lines	0 comments	Download
M	net/disk_cache/net_log_parameters.h	View	1 2 3 4 5	6 chunks	+6 lines, -6 lines	0 comments	Download
M	net/http/http_net_log_params.h	View	1 2 3 4 5	4 chunks	+4 lines, -3 lines	0 comments	Download
M	net/http/http_network_session.h	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/http/http_proxy_client_socket_pool.h	View	1 2 3 4 5	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_config.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	net/socket/client_socket_pool.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download
M	net/socket/client_socket_pool_base.h	View	1 2 3 4 5	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/socket/client_socket_pool_base_unittest.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket/client_socket_pool_manager.h	View	1 2 3 4 5	2 chunks	+4 lines, -1 line	0 comments	Download
M	net/socket/socks_client_socket_pool.h	View	1 2 3 4 5	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/socket/ssl_client_socket_pool.h	View	1 2 3 4 5	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/socket/ssl_error_params.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/transport_client_socket_pool.h	View	1 2 3 4 5	1 chunk	+4 lines, -3 lines	0 comments	Download
M	net/socket/transport_client_socket_pool.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/spdy/spdy_session.h	View	1 2 3 4 5	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_session_pool.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/test_server.h	View	1 2 3 4 5	3 chunks	+6 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_netlog_params.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/backend/print_backend.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/backend/print_backend_dummy.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/backend/print_backend_win.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_dialog_gtk_interface.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context.h	View	1 2 3 4 5	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/printing_context_cairo.h	View	1 2 3 4 5	2 chunks	+5 lines, -1 line	0 comments	Download
M	printing/printing_context_mac.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_win.h	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/in_memory_host_config.h	View	1 2 3 4 5	2 chunks	+5 lines, -2 lines	0 comments	Download
M	remoting/host/json_host_config.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/cros.DEPS/DEPS	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_group.h	View	1 2 3 4 5	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/7259019/diff/1/chrome/common/extensions/extension_l10n_util.h File chrome/common/extensions/extension_l10n_util.h (right): http://codereview.chromium.org/7259019/diff/1/chrome/common/extensions/extension_l10n_util.h#newcode26 chrome/common/extensions/extension_l10n_util.h:26: using base::DictionaryValue; We shouldn't have this in header files ...

9 years, 5 months ago (2011-07-07 16:05:08 UTC) #1

dmazzoni

Compiles on Linux, just working on the last few Win, Mac & Chrome OS issues ...

9 years, 5 months ago (2011-07-07 22:56:59 UTC) #2

dmazzoni

Now compiles on win, mac, & linux trybots - failures are just flaky test failures. ...

9 years, 5 months ago (2011-07-08 14:56:07 UTC) #3

LGTM, thanks and good luck!

Expand Messages | Collapse Messages