Move base/values.h into the base namespace.

chrome/common/extensions/extension_l10n_util.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares extension specific l10n utils.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_L10N_UTIL_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_L10N_UTIL_H_
 #pragma once
 
 #include <set>
 #include <string>
 #include <vector>
 
-class DictionaryValue;
 class Extension;
 class ExtensionMessageBundle;
 class FilePath;
 class GURL;
 class ResourceDispatcherHostRequestInfo;
 struct ExtensionInfo;
 
+namespace base {
+class DictionaryValue;
+}
+
+using base::DictionaryValue;

[brettw, 2011/07/07 16:05:08]

We shouldn't have this in header files other than the base/values.h one.

[dmazzoni, 2011/07/07 22:57:00]

Done.

+
 namespace extension_l10n_util {
 
 // Set the locale for this process to a fixed value, rather than using the
 // normal file-based lookup mechanisms. This is used to set the locale inside
 // the sandboxed utility process, where file reading is not allowed.
 void SetProcessLocale(const std::string& locale);
 
 // Returns default locale in form "en-US" or "sr" or empty string if
 // "default_locale" section was not defined in the manifest.json file.
 std::string GetDefaultLocaleFromManifest(const DictionaryValue& manifest,
@@ skipping 61 matching lines @@
 // |locales_path| is extension_id/_locales
 // |locale_path| is extension_id/_locales/xx
 // |all_locales| is a set of all valid Chrome locales.
 bool ShouldSkipValidation(const FilePath& locales_path,
                           const FilePath& locale_path,
                           const std::set<std::string>& all_locales);
 
 }  // namespace extension_l10n_util
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_L10N_UTIL_H_