Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: content/browser/debugger/debugger_remote_service.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/debugger_host.h ('k') | content/browser/debugger/devtools_remote_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/debugger_remote_service.h
===================================================================
--- content/browser/debugger/debugger_remote_service.h (revision 92173)
+++ content/browser/debugger/debugger_remote_service.h (working copy)
@@ -16,9 +16,12 @@
class DevToolsProtocolHandler;
class DevToolsRemoteMessage;
+class TabContents;
+
+namespace base {
class DictionaryValue;
class Value;
-class TabContents;
+}
// Contains constants for DebuggerRemoteService tool protocol commands
// (V8-related only).
@@ -58,7 +61,7 @@
// as the "result" field in |response|, otherwise the result
// will not be propagated back to the caller.
void DetachFromTab(const std::string& destination,
- DictionaryValue* response);
+ base::DictionaryValue* response);
// DevToolsRemoteListener interface.
@@ -89,7 +92,7 @@
// Attaches a remote debugger to the tab specified by |destination|.
// Writes the attachment result (one of Result enum values) into |response|.
void AttachToTab(const std::string& destination,
- DictionaryValue* response);
+ base::DictionaryValue* response);
// Retrieves a WebContents instance for the specified |tab_uid|
// or NULL if no such tab is found or no WebContents instance
@@ -98,7 +101,7 @@
// Sends a JSON message with the |response| to the remote debugger.
// |tool| and |destination| are used as the respective header values.
- void SendResponse(const Value& response,
+ void SendResponse(const base::Value& response,
const std::string& tool,
const std::string& destination);
@@ -106,15 +109,15 @@
// with the |tab_uid| and writes the result into |response| if it becomes
// known immediately.
bool DispatchDebuggerCommand(int tab_uid,
- DictionaryValue* content,
- DictionaryValue* response);
+ base::DictionaryValue* content,
+ base::DictionaryValue* response);
// Redirects a Javascript evaluation command from |content| to
// a V8 debugger associated with the |tab_uid| and writes the result
// into |response| if it becomes known immediately.
bool DispatchEvaluateJavascript(int tab_uid,
- DictionaryValue* content,
- DictionaryValue* response);
+ base::DictionaryValue* content,
+ base::DictionaryValue* response);
// The delegate is used to get an InspectableTabProxy instance.
DevToolsProtocolHandler* delegate_;
« no previous file with comments | « content/browser/debugger/debugger_host.h ('k') | content/browser/debugger/devtools_remote_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698