Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: chrome/browser/extensions/extension_function.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_function.h
===================================================================
--- chrome/browser/extensions/extension_function.h (revision 92173)
+++ chrome/browser/extensions/extension_function.h (working copy)
@@ -27,10 +27,13 @@
class ExtensionFunctionDispatcher;
class UIThreadExtensionFunction;
class IOThreadExtensionFunction;
-class ListValue;
class QuotaLimitHeuristic;
class RenderViewHost;
+
+namespace base {
+class ListValue;
class Value;
+}
#define EXTENSION_FUNCTION_VALIDATE(test) do { \
if (!(test)) { \
@@ -81,7 +84,7 @@
std::list<QuotaLimitHeuristic*>* heuristics) const {}
// Specifies the raw arguments to the function, as a JSON value.
- virtual void SetArgs(const ListValue* args);
+ virtual void SetArgs(const base::ListValue* args);
// Retrieves the results of the function as a JSON-encoded string (may
// be empty).
@@ -176,11 +179,11 @@
bool user_gesture_;
// The arguments to the API. Only non-null if argument were specified.
- scoped_ptr<ListValue> args_;
+ scoped_ptr<base::ListValue> args_;
// The result of the API. This should be populated by the derived class before
// SendResponse() is called.
- scoped_ptr<Value> result_;
+ scoped_ptr<base::Value> result_;
// Any detailed error from the API. This should be populated by the derived
// class before Run() returns.

Powered by Google App Engine
This is Rietveld 408576698