Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3994)

Unified Diff: chrome/common/persistent_pref_store.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/google_service_auth_error.h ('k') | chrome/common/pref_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/persistent_pref_store.h
===================================================================
--- chrome/common/persistent_pref_store.h (revision 92173)
+++ chrome/common/persistent_pref_store.h (working copy)
@@ -43,7 +43,7 @@
// Equivalent to PrefStore::GetValue but returns a mutable value.
virtual ReadResult GetMutableValue(const std::string& key,
- Value** result) = 0;
+ base::Value** result) = 0;
// Triggers a value changed notification. This function needs to be called
// if one retrieves a list or dictionary with GetMutableValue and change its
@@ -53,13 +53,13 @@
// Sets a |value| for |key| in the store. Assumes ownership of |value|, which
// must be non-NULL.
- virtual void SetValue(const std::string& key, Value* value) = 0;
+ virtual void SetValue(const std::string& key, base::Value* value) = 0;
// Same as SetValue, but doesn't generate notifications. This is used by
// PrefService::GetMutableUserPref() in order to put empty entries
// into the user pref store. Using SetValue is not an option since existing
// tests rely on the number of notifications generated.
- virtual void SetValueSilently(const std::string& key, Value* value) = 0;
+ virtual void SetValueSilently(const std::string& key, base::Value* value) = 0;
// Removes the value for |key|.
virtual void RemoveValue(const std::string& key) = 0;
« no previous file with comments | « chrome/common/net/gaia/google_service_auth_error.h ('k') | chrome/common/pref_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698