Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6934)

Unified Diff: chrome/browser/printing/print_dialog_cloud_internal.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_dialog_cloud_internal.h
===================================================================
--- chrome/browser/printing/print_dialog_cloud_internal.h (revision 92173)
+++ chrome/browser/printing/print_dialog_cloud_internal.h (working copy)
@@ -18,9 +18,14 @@
#include "content/common/notification_registrar.h"
class GURL;
-class StringValue;
class CloudPrintHtmlDialogDelegateTest;
+namespace base {
+class ListValue;
+class StringValue;
+class Value;
+}
+
namespace internal_cloud_print_helpers {
// Small class to virtualize a few functions to aid with unit testing.
@@ -33,10 +38,10 @@
// facilitate unit testing.
virtual void CallJavascriptFunction(const std::wstring& function_name);
virtual void CallJavascriptFunction(const std::wstring& function_name,
- const Value& arg);
+ const base::Value& arg);
virtual void CallJavascriptFunction(const std::wstring& function_name,
- const Value& arg1,
- const Value& arg2);
+ const base::Value& arg1,
+ const base::Value& arg2);
private:
WebUI* web_ui_;
@@ -73,7 +78,7 @@
base::Lock lock_;
CloudPrintDataSenderHelper* volatile helper_;
- scoped_ptr<StringValue> print_data_;
+ scoped_ptr<base::StringValue> print_data_;
string16 print_job_title_;
std::string file_type_;
@@ -106,9 +111,9 @@
const NotificationDetails& details);
// Callbacks from the page.
- void HandleShowDebugger(const ListValue* args);
- void HandleSendPrintData(const ListValue* args);
- void HandleSetPageParameters(const ListValue* args);
+ void HandleShowDebugger(const base::ListValue* args);
+ void HandleSendPrintData(const base::ListValue* args);
+ void HandleSetPageParameters(const base::ListValue* args);
virtual void SetDialogDelegate(CloudPrintHtmlDialogDelegate *delegate);
void StoreDialogClientSize() const;
« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_setup_flow.h ('k') | chrome/browser/printing/print_dialog_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698